Skip to content

Commit 7b8d293

Browse files
authored
Chart: Add controller.progressDeadlineSeconds. (#12017)
1 parent 8d6435b commit 7b8d293

File tree

4 files changed

+16
-0
lines changed

4 files changed

+16
-0
lines changed

charts/ingress-nginx/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -412,6 +412,7 @@ As of version `1.26.0` of this chart, by simply not providing any clusterIP valu
412412
| controller.podLabels | object | `{}` | Labels to add to the pod container metadata |
413413
| controller.podSecurityContext | object | `{}` | Security context for controller pods |
414414
| controller.priorityClassName | string | `""` | |
415+
| controller.progressDeadlineSeconds | int | `0` | Specifies the number of seconds you want to wait for the controller deployment to progress before the system reports back that it has failed. Ref.: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#progress-deadline-seconds |
415416
| controller.proxySetHeaders | object | `{}` | Will add custom headers before sending traffic to backends according to https://github.com/kubernetes/ingress-nginx/tree/main/docs/examples/customization/custom-headers |
416417
| controller.publishService | object | `{"enabled":true,"pathOverride":""}` | Allows customization of the source of the IP address or FQDN to report in the ingress status field. By default, it reads the information provided by the service. If disable, the status field reports the IP address of the node or nodes where an ingress controller pod is running. |
417418
| controller.publishService.enabled | bool | `true` | Enable 'publishService' or not |

charts/ingress-nginx/templates/controller-deployment.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ spec:
2222
replicas: {{ .Values.controller.replicaCount }}
2323
{{- end }}
2424
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
25+
{{- if .Values.controller.progressDeadlineSeconds }}
26+
progressDeadlineSeconds: {{ .Values.controller.progressDeadlineSeconds }}
27+
{{- end }}
2528
{{- if .Values.controller.updateStrategy }}
2629
strategy: {{ toYaml .Values.controller.updateStrategy | nindent 4 }}
2730
{{- end }}

charts/ingress-nginx/tests/controller-deployment_test.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,3 +177,11 @@ tests:
177177
- equal:
178178
path: spec.template.spec.containers[0].image
179179
value: registry.k8s.io/ingress-nginx/controller:my-little-custom-tag@sha256:faa2d18687f734994b6bd9e309e7a73852a81c30e1b8f63165fcd4f0a087e3cd
180+
181+
- it: should create a Deployment with `progressDeadlineSeconds` if `controller.progressDeadlineSeconds` is set
182+
set:
183+
controller.progressDeadlineSeconds: 111
184+
asserts:
185+
- equal:
186+
path: spec.progressDeadlineSeconds
187+
value: 111

charts/ingress-nginx/values.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,10 @@ controller:
236236
# maxUnavailable: 1
237237
# type: RollingUpdate
238238

239+
# -- Specifies the number of seconds you want to wait for the controller deployment to progress before the system reports back that it has failed.
240+
# Ref.: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#progress-deadline-seconds
241+
progressDeadlineSeconds: 0
242+
239243
# -- `minReadySeconds` to avoid killing pods before we are ready
240244
##
241245
minReadySeconds: 0

0 commit comments

Comments
 (0)