Skip to content

Commit b6239d6

Browse files
authored
Merge pull request #404 from aramase/buildx
fix: windows image build with buildx
2 parents 38187b3 + 2e0d68d commit b6239d6

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,10 @@ setup-kind:
123123
.PHONY: e2e-container
124124
e2e-container:
125125
docker buildx rm container-builder || true
126-
docker buildx create --use --name=container-builder
126+
# only moby/buildkit:foreign-mediatype works on building Windows image now
127+
# https://github.com/moby/buildkit/pull/1879
128+
# Github issue: https://github.com/moby/buildkit/issues/1877
129+
docker buildx create --use --name=container-builder --driver-opt image=moby/buildkit:v0.7.2
127130
ifdef TEST_WINDOWS
128131
docker buildx build --no-cache --build-arg LDFLAGS=$(LDFLAGS) -t $(IMAGE_TAG)-linux-amd64 -f docker/Dockerfile --platform="linux/amd64" --push .
129132
docker buildx build --no-cache --build-arg LDFLAGS=$(LDFLAGS) -t $(IMAGE_TAG)-windows-1809-amd64 -f docker/windows.Dockerfile --platform="windows/amd64" --push .

0 commit comments

Comments
 (0)