Skip to content

Commit 8be9e33

Browse files
committed
Allow the 'updateStrategy' of the Daemonset to be configured in Helm
This PR enables the 'updateStrategy' of the Daemonset to be configured by Helm parameters. This has two different parameters, one for Linux and one for Windows, following the existing pattern for these variables. The default values are the same as the current defaults; RollingUpdate strategy with maxUnavailable set to 1, so behavior will change only if the user specifies a custom value.
1 parent f94a5cb commit 8be9e33

File tree

4 files changed

+16
-0
lines changed

4 files changed

+16
-0
lines changed

manifest_staging/charts/secrets-store-csi-driver/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ The following table lists the configurable parameters of the csi-secrets-store-p
4242
| `linux.livenessProbe.resources` | The resource request/limits for the linux liveness-probe container image | `limits: 100m CPU, 100Mi; requests: 10m CPU, 20Mi` |
4343
| `linux.env` | Environment variables to be passed for the daemonset on linux nodes | `[]` |
4444
| `linux.priorityClassName` | Indicates the importance of a Pod relative to other Pods. | `""` |
45+
| `linux.updateStrategy` | Configure a custom update strategy for the daemonset on linux nodes | `RollingUpdate with 1 maxUnavailable` |
4546
| `windows.image.repository` | Windows image repository | `us.gcr.io/k8s-artifacts-prod/csi-secrets-store/driver` |
4647
| `windows.image.pullPolicy` | Windows image pull policy | `IfNotPresent` |
4748
| `windows.image.tag` | Windows image tag | `v0.0.16` |
@@ -61,6 +62,7 @@ The following table lists the configurable parameters of the csi-secrets-store-p
6162
| `windows.livenessProbe.resources` | The resource request/limits for the windows liveness-probe container image | `limits: 200m CPU, 200Mi; requests: 10m CPU, 20Mi` |
6263
| `windows.env` | Environment variables to be passed for the daemonset on windows nodes | `[]` |
6364
| `windows.priorityClassName` | Indicates the importance of a Pod relative to other Pods. | `""` |
65+
| `windows.updateStrategy` | Configure a custom update strategy for the daemonset on windows nodes | `RollingUpdate with 1 maxUnavailable` |
6466
| `logLevel.debug` | Enable debug logging | true |
6567
| `livenessProbe.port` | Liveness probe port | `9808` |
6668
| `livenessProbe.logLevel` | Liveness probe container logging verbosity level | `2` |

manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver-windows.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ spec:
99
selector:
1010
matchLabels:
1111
app: {{ template "sscd.name" . }}
12+
updateStrategy:
13+
{{ toYaml .Values.windows.updateStrategy | indent 4 }}
1214
template:
1315
metadata:
1416
{{ include "sscd.labels" . | indent 6 }}

manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ spec:
99
selector:
1010
matchLabels:
1111
app: {{ template "sscd.name" . }}
12+
updateStrategy:
13+
{{ toYaml .Values.linux.updateStrategy | indent 4 }}
1214
template:
1315
metadata:
1416
{{ include "sscd.labels" . | indent 6 }}

manifest_staging/charts/secrets-store-csi-driver/values.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,11 @@ linux:
4242
cpu: 10m
4343
memory: 20Mi
4444

45+
updateStrategy:
46+
type: RollingUpdate
47+
rollingUpdate:
48+
maxUnavailable: 1
49+
4550
kubeletRootDir: /var/lib/kubelet
4651
nodeSelector: {}
4752
tolerations: []
@@ -93,6 +98,11 @@ windows:
9398
cpu: 10m
9499
memory: 20Mi
95100

101+
updateStrategy:
102+
type: RollingUpdate
103+
rollingUpdate:
104+
maxUnavailable: 1
105+
96106
kubeletRootDir: C:\var\lib\kubelet
97107
nodeSelector: {}
98108
tolerations: []

0 commit comments

Comments
 (0)