Skip to content

Commit 87b7c86

Browse files
authored
Merge pull request #279 from helayoty/helayoty/helm-246-set-envs
helm: add support for envs in helm chart
2 parents 721a1e9 + da2b4af commit 87b7c86

File tree

4 files changed

+34
-24
lines changed

4 files changed

+34
-24
lines changed

manifest_staging/charts/secrets-store-csi-driver/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ The following table lists the configurable parameters of the csi-secrets-store-p
3737
| `linux.livenessProbeImage.repository` | Linux liveness-probe image repository | `quay.io/k8scsi/livenessprobe` |
3838
| `linux.livenessProbeImage.pullPolicy` | Linux liveness-probe image pull policy | `Always` |
3939
| `linux.livenessProbeImage.tag` | Linux liveness-probe image tag | `v2.0.0` |
40+
| `linux.env` | Environment variables to be passed for the daemonset on linux nodes | `[]` |
4041
| `windows.image.repository` | Windows image repository | `us.gcr.io/k8s-artifacts-prod/csi-secrets-store/driver` |
4142
| `windows.image.pullPolicy` | Windows image pull policy | `IfNotPresent` |
4243
| `windows.image.tag` | Windows image tag | `v0.0.12` |
@@ -51,6 +52,7 @@ The following table lists the configurable parameters of the csi-secrets-store-p
5152
| `windows.livenessProbeImage.repository` | Windows liveness-probe image repository | `mcr.microsoft.com/oss/kubernetes-csi/livenessprobe` |
5253
| `windows.livenessProbeImage.pullPolicy` | Windows liveness-probe image pull policy | `Always` |
5354
| `windows.livenessProbeImage.tag` | Windows liveness-probe image tag | `v2.0.1-alpha.1-windows-1809-amd64` |
55+
| `windows.env` | Environment variables to be passed for the daemonset on windows nodes | `[]` |
5456
| `logLevel.debug` | Enable debug logging | true |
5557
| `livenessProbe.port` | Liveness probe port | `9808` |
5658
| `livenessProbe.logLevel` | Liveness probe container logging verbosity level | `2` |

manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver-windows.yaml

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ spec:
3131
"del /f C:\\registration\\secrets-store.csi.k8s.io-reg.sock",
3232
]
3333
env:
34-
- name: KUBE_NODE_NAME
35-
valueFrom:
36-
fieldRef:
37-
apiVersion: v1
38-
fieldPath: spec.nodeName
34+
- name: KUBE_NODE_NAME
35+
valueFrom:
36+
fieldRef:
37+
apiVersion: v1
38+
fieldPath: spec.nodeName
3939
imagePullPolicy: {{ .Values.windows.registrarImage.pullPolicy }}
4040
volumeMounts:
4141
- name: plugin-dir
@@ -54,13 +54,16 @@ spec:
5454
{{- end }}
5555
- "--metrics-addr={{ .Values.windows.metricsAddr }}"
5656
env:
57-
- name: CSI_ENDPOINT
58-
value: unix://C:\\csi\\csi.sock
59-
- name: KUBE_NODE_NAME
60-
valueFrom:
61-
fieldRef:
62-
apiVersion: v1
63-
fieldPath: spec.nodeName
57+
{{- with .Values.windows.env }}
58+
{{- toYaml . | nindent 10 }}
59+
{{- end }}
60+
- name: CSI_ENDPOINT
61+
value: unix://C:\\csi\\csi.sock
62+
- name: KUBE_NODE_NAME
63+
valueFrom:
64+
fieldRef:
65+
apiVersion: v1
66+
fieldPath: spec.nodeName
6467
imagePullPolicy: {{ .Values.windows.image.pullPolicy }}
6568
securityContext:
6669
privileged: true

manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver.yaml

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ spec:
3333
"rm -rf /registration/secrets-store.csi.k8s.io-reg.sock",
3434
]
3535
env:
36-
- name: KUBE_NODE_NAME
37-
valueFrom:
38-
fieldRef:
39-
apiVersion: v1
40-
fieldPath: spec.nodeName
36+
- name: KUBE_NODE_NAME
37+
valueFrom:
38+
fieldRef:
39+
apiVersion: v1
40+
fieldPath: spec.nodeName
4141
imagePullPolicy: {{ .Values.linux.registrarImage.pullPolicy }}
4242
volumeMounts:
4343
- name: plugin-dir
@@ -56,13 +56,16 @@ spec:
5656
{{- end }}
5757
- "--metrics-addr={{ .Values.linux.metricsAddr }}"
5858
env:
59-
- name: CSI_ENDPOINT
60-
value: unix:///csi/csi.sock
61-
- name: KUBE_NODE_NAME
62-
valueFrom:
63-
fieldRef:
64-
apiVersion: v1
65-
fieldPath: spec.nodeName
59+
{{- with .Values.linux.env }}
60+
{{- toYaml . | nindent 10 }}
61+
{{- end }}
62+
- name: CSI_ENDPOINT
63+
value: unix:///csi/csi.sock
64+
- name: KUBE_NODE_NAME
65+
valueFrom:
66+
fieldRef:
67+
apiVersion: v1
68+
fieldPath: spec.nodeName
6669
imagePullPolicy: {{ .Values.linux.image.pullPolicy }}
6770
securityContext:
6871
privileged: true

manifest_staging/charts/secrets-store-csi-driver/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ linux:
1616
nodeSelector: {}
1717
tolerations: []
1818
metricsAddr: ":8080"
19+
env: []
1920

2021
windows:
2122
enabled: false
@@ -35,6 +36,7 @@ windows:
3536
nodeSelector: {}
3637
tolerations: []
3738
metricsAddr: ":8080"
39+
env: []
3840

3941
logLevel:
4042
debug: true

0 commit comments

Comments
 (0)