Skip to content

Defer plugin.Version pointer receiver change to v5 #4761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camilamacedo86 opened this issue Apr 5, 2025 · 2 comments
Open

Defer plugin.Version pointer receiver change to v5 #4761

camilamacedo86 opened this issue Apr 5, 2025 · 2 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/blocked

Comments

@camilamacedo86
Copy link
Member

camilamacedo86 commented Apr 5, 2025

This issue tracks PR #4733, which changes plugin.Version methods to use pointer receivers.

The change is breaking for downstream consumers like Operator SDK, which rely on value-based usage.

We should defer this until kubebuilder v5, where breaking changes are allowed.
See: #4733 (comment)

@camilamacedo86 camilamacedo86 added this to the kubebuilder 5x milestone Apr 5, 2025
@camilamacedo86 camilamacedo86 added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 5, 2025
@camilamacedo86
Copy link
Member Author

@kersten

When we have enough requirements that justify a kubebuilder v5. x, we can do this one.

@kersten
Copy link
Contributor

kersten commented Apr 7, 2025

Great! In that case, we should refactor all mixed uses of pointer and value receivers to consistently use pointer receivers throughout the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/blocked
Projects
None yet
Development

No branches or pull requests

2 participants