Merge pull request #4765 from kersten/chore/simple-external-plugin-flag-parsing

📖  handle flag parsing errors in simple external plugin tutorial API scaffolder

Author: k8s-ci-robot

docs/book/src/simple-external-plugin-tutorial/testdata/sampleexternalplugin/v1/scaffolds/api.go

@@ -16,6 +16,8 @@ limitations under the License.
 package scaffolds
 
 import (
+	"fmt"
+
 	"v1/scaffolds/internal/templates/api"
 
 	"github.com/spf13/pflag"
@@ -54,7 +56,13 @@ func ApiCmd(pr *external.PluginRequest) external.PluginResponse {
 	// Here is an example of parsing a flag from a Kubebuilder external plugin request
 	flags := pflag.NewFlagSet("apiFlags", pflag.ContinueOnError)
 	flags.Int("number", 1, "set a number to be added in the scaffolded apiFile.txt")
-	flags.Parse(pr.Args)
+	if err := flags.Parse(pr.Args); err != nil {
+		pluginResponse.Error = true
+		pluginResponse.ErrorMsgs = []string{
+			fmt.Sprintf("failed to parse flags: %s", err.Error()),
+		}
+		return pluginResponse
+	}
 	number, _ := flags.GetInt("number")
 
 	apiFile := api.NewApiFile(api.WithNumber(number))