Merge pull request #4763 from kersten/fix/boilerplate-validate-pointer-receiver

k8s-ci-robot · web-flow · commit 205fcd7959b5 · 2025-04-07T03:28:39.000-07:00
🌱 (chore): use pointer receiver for Validate and rename shadowed var
diff --git a/pkg/plugins/golang/v4/scaffolds/internal/templates/hack/boilerplate.go b/pkg/plugins/golang/v4/scaffolds/internal/templates/hack/boilerplate.go
@@ -48,9 +48,9 @@ type Boilerplate struct {
 }
 
 // Validate implements file.RequiresValidation
-func (f Boilerplate) Validate() error {
+func (f *Boilerplate) Validate() error {
 	if f.License != "" {
-		if _, found := knownLicenses[f.License]; !found {
+		if _, foundKnown := knownLicenses[f.License]; !foundKnown {
 			if _, found := f.Licenses[f.License]; !found {
 				return fmt.Errorf("unknown specified license %s", f.License)
 			}

Original file line number	Diff line number	Diff line change
`@@ -48,9 +48,9 @@ type Boilerplate struct {`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`// Validate implements file.RequiresValidation`
`51`		`-func (f Boilerplate) Validate() error {`
	`51`	`+func (f *Boilerplate) Validate() error {`
`52`	`52`	`if f.License != "" {`
`53`		`- if _, found := knownLicenses[f.License]; !found {`
	`53`	`+ if _, foundKnown := knownLicenses[f.License]; !foundKnown {`
`54`	`54`	`if _, found := f.Licenses[f.License]; !found {`
`55`	`55`	`return fmt.Errorf("unknown specified license %s", f.License)`
`56`	`56`	`}`