Merge pull request #3866 from prashantrewar/apply-latest-lint-rules

 🌱Evaludate and Apply Latest Lint Rules and Features

Author: k8s-ci-robot

.golangci.yml

@@ -26,6 +26,11 @@ linters-settings:
       - name: context-as-argument
       - name: context-keys-type
       - name: dot-imports
+        arguments:
+          # dot import should be ONLY allowed for ginkgo testing packages
+          allowedPackages:
+            - "github.com/onsi/ginkgo/v2"
+            - "github.com/onsi/gomega"
       - name: error-return
       - name: error-strings
       - name: error-naming

docs/book/src/component-config-tutorial/testdata/project/test/e2e/e2e_suite_test.go

@@ -20,9 +20,7 @@ import (
 	"fmt"
 	"testing"
 
-	// nolint:revive
 	. "github.com/onsi/ginkgo/v2"
-	// nolint:revive
 	. "github.com/onsi/gomega"
 )
 

docs/book/src/component-config-tutorial/testdata/project/test/e2e/e2e_test.go

@@ -21,9 +21,7 @@ import (
 	"os/exec"
 	"time"
 
-	// nolint:revive
 	. "github.com/onsi/ginkgo/v2"
-	// nolint:revive
 	. "github.com/onsi/gomega"
 
 	"tutorial.kubebuilder.io/project/test/utils"

docs/book/src/component-config-tutorial/testdata/project/test/utils/utils.go

@@ -22,7 +22,6 @@ import (
 	"os/exec"
 	"strings"
 
-	// nolint:revive
 	. "github.com/onsi/ginkgo/v2" //nolint:golint,revive
 )
 

docs/book/src/cronjob-tutorial/testdata/project/api/v1/cronjob_webhook_test.go

@@ -17,7 +17,6 @@ limitations under the License.
 package v1
 
 import (
-	// nolint:revive
 	. "github.com/onsi/ginkgo/v2"
 )
 

docs/book/src/cronjob-tutorial/testdata/project/api/v1/webhook_suite_test.go

@@ -26,12 +26,10 @@ import (
 	"testing"
 	"time"
 
-	// nolint:revive
 	. "github.com/onsi/ginkgo/v2"
-	// nolint:revive
 	. "github.com/onsi/gomega"
-	admissionv1 "k8s.io/api/admission/v1"
 
+	admissionv1 "k8s.io/api/admission/v1"
 	//+kubebuilder:scaffold:imports
 	apimachineryruntime "k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/client-go/rest"

docs/book/src/cronjob-tutorial/testdata/project/internal/controller/cronjob_controller_test.go

@@ -29,10 +29,8 @@ import (
 	"reflect"
 	"time"
 
-	// nolint:revive
-	. "github.com/onsi/ginkgo/v2"
-	// nolint:revive
-	. "github.com/onsi/gomega"
+    . "github.com/onsi/ginkgo/v2"
+    . "github.com/onsi/gomega"
 	batchv1 "k8s.io/api/batch/v1"
 	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

docs/book/src/cronjob-tutorial/testdata/project/internal/controller/suite_test.go

@@ -34,9 +34,7 @@ import (
 
 	ctrl "sigs.k8s.io/controller-runtime"
 
-	// nolint:revive
 	. "github.com/onsi/ginkgo/v2"
-	// nolint:revive
 	. "github.com/onsi/gomega"
 
 	"k8s.io/client-go/kubernetes/scheme"

docs/book/src/cronjob-tutorial/testdata/project/test/e2e/e2e_suite_test.go

@@ -20,9 +20,7 @@ import (
 	"fmt"
 	"testing"
 
-	// nolint:revive
 	. "github.com/onsi/ginkgo/v2"
-	// nolint:revive
 	. "github.com/onsi/gomega"
 )
 

docs/book/src/cronjob-tutorial/testdata/project/test/e2e/e2e_test.go

@@ -21,9 +21,7 @@ import (
 	"os/exec"
 	"time"
 
-	// nolint:revive
 	. "github.com/onsi/ginkgo/v2"
-	// nolint:revive
 	. "github.com/onsi/gomega"
 
 	"tutorial.kubebuilder.io/project/test/utils"