Merge pull request #4693 from kersten/chore/crd-version-conversion-doc

k8s-ci-robot · web-flow · commit 136851551e6f · 2025-03-27T09:26:57.000-07:00
📖 Improve error format in the design docs for API Versioning in Kubebuilder
diff --git a/designs/crd_version_conversion.md b/designs/crd_version_conversion.md
@@ -158,12 +158,12 @@ func (ch *conversionHandler) convertObject(src, dst runtime.Object) error {
 
     err = src.(conversion.Convertible).ConvertTo(hub)
     if err != nil {
-        return fmt.Errorf("%T failed to convert to hub version %T : %v", src, hub, err)
+        return fmt.Errorf("%T failed to convert to hub version %T : %w", src, hub, err)
     }
 
     err = dst.(conversion.Convertible).ConvertFrom(hub)
     if err != nil {
-        return fmt.Errorf("%T failed to convert from hub version %T : %v", dst, hub, err)
+        return fmt.Errorf("%T failed to convert from hub version %T : %w", dst, hub, err)
     }
     return nil
 }

Original file line number	Diff line number	Diff line change
`@@ -158,12 +158,12 @@ func (ch *conversionHandler) convertObject(src, dst runtime.Object) error {`
`158`	`158`
`159`	`159`	`err = src.(conversion.Convertible).ConvertTo(hub)`
`160`	`160`	`if err != nil {`
`161`		`- return fmt.Errorf("%T failed to convert to hub version %T : %v", src, hub, err)`
	`161`	`+ return fmt.Errorf("%T failed to convert to hub version %T : %w", src, hub, err)`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`err = dst.(conversion.Convertible).ConvertFrom(hub)`
`165`	`165`	`if err != nil {`
`166`		`- return fmt.Errorf("%T failed to convert from hub version %T : %v", dst, hub, err)`
	`166`	`+ return fmt.Errorf("%T failed to convert from hub version %T : %w", dst, hub, err)`
`167`	`167`	`}`
`168`	`168`	`return nil`
`169`	`169`	`}`