Skip to content

Commit 011383c

Browse files
authored
Merge pull request #3797 from sarthaksarthak9/label1
🐛(kustomize/v2, go/v4, deploy-image/v1-alpha): Fix labels according to conventions and conveys. app.kubernetes.io/name now have the ProjectName and the labels app.kubernetes.io/instance, app.kubernetes.io/component, app.kubernetes.io/created-by, app.kubernetes.io/part-of were removed
2 parents bbd19fe + 9754036 commit 011383c

File tree

48 files changed

+54
-220
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+54
-220
lines changed

docs/book/src/component-config-tutorial/testdata/project/config/rbac/service_account.yaml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@ apiVersion: v1
22
kind: ServiceAccount
33
metadata:
44
labels:
5-
app.kubernetes.io/name: serviceaccount
6-
app.kubernetes.io/instance: controller-manager-sa
7-
app.kubernetes.io/component: rbac
8-
app.kubernetes.io/created-by: project
9-
app.kubernetes.io/part-of: project
5+
app.kubernetes.io/name: project
106
app.kubernetes.io/managed-by: kustomize
117
name: controller-manager
128
namespace: system

docs/book/src/component-config-tutorial/testdata/project/config/samples/config_v2_projectconfig.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,8 @@ apiVersion: config.tutorial.kubebuilder.io/v2
22
kind: ProjectConfig
33
metadata:
44
labels:
5-
app.kubernetes.io/name: projectconfig
6-
app.kubernetes.io/instance: projectconfig-sample
7-
app.kubernetes.io/part-of: project
5+
app.kubernetes.io/name: project
86
app.kubernetes.io/managed-by: kustomize
9-
app.kubernetes.io/created-by: project
107
name: projectconfig-sample
118
spec:
129
# TODO(user): Add fields here

docs/book/src/cronjob-tutorial/testdata/project/config/rbac/service_account.yaml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@ apiVersion: v1
22
kind: ServiceAccount
33
metadata:
44
labels:
5-
app.kubernetes.io/name: serviceaccount
6-
app.kubernetes.io/instance: controller-manager-sa
7-
app.kubernetes.io/component: rbac
8-
app.kubernetes.io/created-by: project
9-
app.kubernetes.io/part-of: project
5+
app.kubernetes.io/name: project
106
app.kubernetes.io/managed-by: kustomize
117
name: controller-manager
128
namespace: system

docs/book/src/cronjob-tutorial/testdata/project/config/samples/batch_v1_cronjob.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,8 @@ apiVersion: batch.tutorial.kubebuilder.io/v1
22
kind: CronJob
33
metadata:
44
labels:
5-
app.kubernetes.io/name: cronjob
6-
app.kubernetes.io/instance: cronjob-sample
7-
app.kubernetes.io/part-of: project
5+
app.kubernetes.io/name: project
86
app.kubernetes.io/managed-by: kustomize
9-
app.kubernetes.io/created-by: project
107
name: cronjob-sample
118
spec:
129
schedule: "*/1 * * * *"

docs/book/src/cronjob-tutorial/testdata/project/config/webhook/service.yaml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@ apiVersion: v1
22
kind: Service
33
metadata:
44
labels:
5-
app.kubernetes.io/name: service
6-
app.kubernetes.io/instance: webhook-service
7-
app.kubernetes.io/component: webhook
8-
app.kubernetes.io/created-by: project
9-
app.kubernetes.io/part-of: project
5+
app.kubernetes.io/name: project
106
app.kubernetes.io/managed-by: kustomize
117
name: webhook-service
128
namespace: system

docs/book/src/getting-started/testdata/project/config/rbac/service_account.yaml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@ apiVersion: v1
22
kind: ServiceAccount
33
metadata:
44
labels:
5-
app.kubernetes.io/name: serviceaccount
6-
app.kubernetes.io/instance: controller-manager-sa
7-
app.kubernetes.io/component: rbac
8-
app.kubernetes.io/created-by: project
9-
app.kubernetes.io/part-of: project
5+
app.kubernetes.io/name: project
106
app.kubernetes.io/managed-by: kustomize
117
name: controller-manager
128
namespace: system

docs/book/src/getting-started/testdata/project/internal/controller/memcached_controller.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -409,11 +409,9 @@ func labelsForMemcached(name string) map[string]string {
409409
if err == nil {
410410
imageTag = strings.Split(image, ":")[1]
411411
}
412-
return map[string]string{"app.kubernetes.io/name": "Memcached",
413-
"app.kubernetes.io/instance": name,
412+
return map[string]string{"app.kubernetes.io/name": "project",
414413
"app.kubernetes.io/version": imageTag,
415-
"app.kubernetes.io/part-of": "project",
416-
"app.kubernetes.io/created-by": "controller-manager",
414+
"app.kubernetes.io/managed-by": "MemcachedController",
417415
}
418416
}
419417

pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/rbac/service_account.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,7 @@ const serviceAccountTemplate = `apiVersion: v1
4545
kind: ServiceAccount
4646
metadata:
4747
labels:
48-
app.kubernetes.io/name: serviceaccount
49-
app.kubernetes.io/instance: controller-manager-sa
50-
app.kubernetes.io/component: rbac
51-
app.kubernetes.io/created-by: {{ .ProjectName }}
52-
app.kubernetes.io/part-of: {{ .ProjectName }}
48+
app.kubernetes.io/name: {{ .ProjectName }}
5349
app.kubernetes.io/managed-by: kustomize
5450
name: controller-manager
5551
namespace: system

pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/samples/crd_sample.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,8 @@ const crdSampleTemplate = `apiVersion: {{ .Resource.QualifiedGroup }}/{{ .Resour
5555
kind: {{ .Resource.Kind }}
5656
metadata:
5757
labels:
58-
app.kubernetes.io/name: {{ lower .Resource.Kind }}
59-
app.kubernetes.io/instance: {{ lower .Resource.Kind }}-sample
60-
app.kubernetes.io/part-of: {{ .ProjectName }}
58+
app.kubernetes.io/name: {{ .ProjectName }}
6159
app.kubernetes.io/managed-by: kustomize
62-
app.kubernetes.io/created-by: {{ .ProjectName }}
6360
name: {{ lower .Resource.Kind }}-sample
6461
spec:
6562
# TODO(user): Add fields here

pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/webhook/service.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,7 @@ const serviceTemplate = `apiVersion: v1
4848
kind: Service
4949
metadata:
5050
labels:
51-
app.kubernetes.io/name: service
52-
app.kubernetes.io/instance: webhook-service
53-
app.kubernetes.io/component: webhook
54-
app.kubernetes.io/created-by: {{ .ProjectName }}
55-
app.kubernetes.io/part-of: {{ .ProjectName }}
51+
app.kubernetes.io/name: {{ .ProjectName }}
5652
app.kubernetes.io/managed-by: kustomize
5753
name: webhook-service
5854
namespace: system

0 commit comments

Comments
 (0)