Merge pull request #329 from yuwenma/applyset-health

k8s-ci-robot · web-flow · commit eac933c28f94 · 2023-04-25T13:46:16.000-07:00
fix: catch unknown kstatus value
diff --git a/applylib/applyset/health.go b/applylib/applyset/health.go
@@ -42,8 +42,11 @@ func isHealthy(u *unstructured.Unstructured) bool {
 	case status.UnknownStatus:
 		klog.Warningf("unknown status for %s", humanName(u))
 		return false
-	default: // status.CurrentStatus:
+	case status.CurrentStatus:
 		return true
+	default:
+		klog.Warningf("unknown status value %s", result.Status)
+		return false
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,11 @@ func isHealthy(u *unstructured.Unstructured) bool {`
`42`	`42`	`case status.UnknownStatus:`
`43`	`43`	`klog.Warningf("unknown status for %s", humanName(u))`
`44`	`44`	`return false`
`45`		`- default: // status.CurrentStatus:`
	`45`	`+ case status.CurrentStatus:`
`46`	`46`	`return true`
	`47`	`+ default:`
	`48`	`+ klog.Warningf("unknown status value %s", result.Status)`
	`49`	`+ return false`
`47`	`50`	`}`
`48`	`51`	`}`
`49`	`52`