simplify without-kustomize tag

Author: yuwenma

pkg/patterns/declarative/kustomize/disabled.go

@@ -5,23 +5,12 @@ package kustomize
 
 import (
 	"context"
+	"fmt"
 
-	"sigs.k8s.io/controller-runtime/pkg/log"
 	"sigs.k8s.io/kustomize/kyaml/filesys"
 )
 
-func init() {
-	Kustomize = &SkipKustomize{}
-}
-
-var _ Kustomizer = &SkipKustomize{}
-
-// NoopKustomize ignore the `kustomization.yaml` file and won't run `kustomize build`.
-type SkipKustomize struct{}
-
-// Run is a no-op
-func (k *SkipKustomize) Run(ctx context.Context, _ filesys.FileSystem, _ string) ([]byte, error) {
-	log := log.FromContext(ctx)
-	log.WithValues("kustomizer", "SkipKustomize").Info("skip running kustomize")
-	return nil, nil
+// Run ignore the `kustomization.yaml` file and won't run `kustomize build`.
+func Run(_ context.Context, _ filesys.FileSystem, _ string) ([]byte, error) {
+	return nil, fmt.Errorf("kustomize support is not compiled in (built with tag `without_kustomize`)")
 }

pkg/patterns/declarative/kustomize/enabled.go

@@ -1,3 +1,6 @@
+//go:build !without_kustomize
+// +build !without_kustomize
+
 package kustomize
 
 import (
@@ -9,19 +12,11 @@ import (
 	"sigs.k8s.io/kustomize/kyaml/filesys"
 )
 
-func init() {
-	Kustomize = &EnabledKustomize{}
-}
-
-var _ Kustomizer = &EnabledKustomize{}
-
-// EnabledKustomize runs kustomize build. It requires kustomize/api v0.12.1 and above
-type EnabledKustomize struct{}
-
-// Run calls the kustomize/api library to run `kustomize build`.
-func (k *EnabledKustomize) Run(ctx context.Context, fs filesys.FileSystem, manifestPath string) ([]byte, error) {
+// Run calls the kustomize/api library to run `kustomize build`. This method is differentiated by go build
+// tag `without-kustomize`
+func Run(ctx context.Context, fs filesys.FileSystem, manifestPath string) ([]byte, error) {
 	log := log.FromContext(ctx)
-	log.WithValues("kustomizer", "EnabledKustomize").Info("running kustomize")
+	log.WithValues("manifestPath", manifestPath).Info("running kustomize")
 	// run kustomize to create final manifest
 	opts := krusty.MakeDefaultOptions()
 	kustomizer := krusty.MakeKustomizer(opts)

pkg/patterns/declarative/kustomize/kustomizer.go

@@ -390,7 +390,7 @@ func (r *Reconciler) BuildDeploymentObjectsWithFs(ctx context.Context, name type
 	// Here, the manifest is built using Kustomize and then replaces the Object items with the created manifest
 	if r.IsKustomizeOptionUsed() {
 		// run kustomize to create final manifest
-		manifestYaml, err := kustomize.Kustomize.Run(ctx, fs, manifestObjects.Path)
+		manifestYaml, err := kustomize.Run(ctx, fs, manifestObjects.Path)
 		if err != nil {
 			log.Error(err, "run kustomize build")
 			return nil, fmt.Errorf("error running kustomize: %v", err)