Skip to content

Conversation

@krishagarwal278
Copy link
Contributor

@JoelSpeed I've updated the README to fix the installation issues.

Main changes:

  • Module mode now uses v2.5.0 and includes the pseudo-version format you showed in the cluster-api example, plus instructions on how to generate it
  • Fixed the plugin build instructions to use the vendor directory like you suggested:
    go mod vendor
    go build -mod=vendor -buildmode=plugin -o bin/kube-api-linter.so ./vendor/sigs.k8s.io/kube-api-linter
  • Added version: "2" to all the .golangci.yml examples
  • Fixed up the Makefile and standalone build docs to be consistent with the actual directory structure

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krishagarwal278
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2025
@krishagarwal278
Copy link
Contributor Author

I've tested the standalone binary build with make build and it works fine. Let me know if anything needs adjusting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants