Add configuration for goreleaser #173
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
| footer: >- | ||
|
|
||
| --- | ||
|
|
||
| Released by [GoReleaser](https://github.com/goreleaser/goreleaser). |
There was a problem hiding this comment.
Is this a valid configuration? It looks like this is supposed to only be available in the Pro version 🫠
There was a problem hiding this comment.
It came by default, so I assume it's allowed?
| filters: | ||
| exclude: | ||
| - "^docs:" | ||
| - "^test:" |
There was a problem hiding this comment.
Out of scope for this PR, but this makes me think we should probably start enforcing a commit formatting convention so we can more reliably remove things we think aren't applicable to include in the changelogs.
Probably also just good hygiene anyways 🤷
There was a problem hiding this comment.
Yeah I'll check what others are doing in this regard, I think CAPI/controller-runtime both have a fairly reasonable pattern
.github/workflows/release.yaml
Outdated
| version: "~> v2" | ||
| args: release --clean | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GH_PAT }} |
There was a problem hiding this comment.
I hope you aren't using a personal access token to your github account like this signals.
AFAIK, the general convention is to use ${{ secrets.GITHUB_TOKEN }} and then toggle on the read/write permissions in the repository "Actions" settings so that the token is limited to the surface area of the repository.
JoelSpeed
force-pushed
the
goreleaser-config
branch
from
20d89d9 to
f9a03ff
Compare
3 participants
This adds configuration for goreleaser to automatically publish new releases when we publish git tags.
We have had requests for published binaries from at least one community so I think this makes sense.
Hoping to publish v0.1.0 soon 👀