Address review comments

Author: Karthik-K-N

pkg/analysis/helpers/extractjsontags/analyzer.go

@@ -25,7 +25,7 @@ import (
 	"golang.org/x/tools/go/analysis"
 	"golang.org/x/tools/go/analysis/passes/inspect"
 	"golang.org/x/tools/go/ast/inspector"
-
+	"k8s.io/utils/set"
 	kalerrors "sigs.k8s.io/kube-api-linter/pkg/analysis/errors"
 )
 
@@ -142,15 +142,15 @@ func extractTagInfo(tag *ast.BasicLit) FieldTagInfo {
 	}
 
 	tagName := tagValues[0]
+	tagSet := set.New[string](tagValues...)
 
 	return FieldTagInfo{
 		Name:      tagName,
-		OmitEmpty: (len(tagValues) == 2 && tagValues[1] == omitEmpty) || (len(tagValues) == 3 && (tagValues[1] == omitEmpty || tagValues[2] == omitEmpty)),
-		// Considering, omitzero will always coexist with omitemtpy and it can be either second or third tag.
-		OmitZero: len(tagValues) == 3 && (tagValues[1] == omitZero || tagValues[2] == omitZero),
-		RawValue: tagValue,
-		Pos:      pos,
-		End:      end,
+		OmitEmpty: tagSet.Has(omitEmpty),
+		OmitZero:  tagSet.Has(omitZero),
+		RawValue:  tagValue,
+		Pos:       pos,
+		End:       end,
 	}
 }
 

pkg/analysis/optionalfields/testdata/src/b/a.go

@@ -171,10 +171,15 @@ type A struct {
 	// +optional
 	StructWithMinProperties B `json:"structWithMinProperties,omitempty"` // want "field StructWithMinProperties is optional and should be a pointer"
 
-	// StructWithMinPropertiesAndOmitEmptyTag is a struct field with a minimum number of properties.
+	// structWithMinPropertiesAndOmitEmptyAndOmitZero is a struct field with a minimum number of properties and has both omitzero and omitemtpy tag.
 	// +kubebuilder:validation:MinProperties=1
 	// +optional
-	StructWithMinPropertiesAndOmitEmptyTag B `json:"structWithMinPropertiesAndOmitEmptyTag,omitempty,omitzero"`
+	StructWithMinPropertiesAndOmitEmptyAndOmitZero B `json:"structWithMinPropertiesAndOmitEmptyAndOmitZero,omitempty,omitzero"`
+
+	// structWithOnlyOmitZeroTag is a struct field with a minimum number of properties and has only omitzero tag.
+	// +kubebuilder:validation:MinProperties=1
+	// +optional
+	StructWithOnlyOmitZeroTag B `json:"structWithOnlyOmitZeroTag,omitzero"` // want "field StructWithOnlyOmitZeroTag is optional and should have the omitempty tag"
 
 	// structWithMinPropertiesOnStruct is a struct field with a minimum number of properties on the struct.
 	// +optional

pkg/analysis/optionalfields/testdata/src/b/a.go.golden

@@ -171,10 +171,15 @@ type A struct {
 	// +optional
 	StructWithMinProperties *B `json:"structWithMinProperties,omitempty"` // want "field StructWithMinProperties is optional and should be a pointer"
 
-	// StructWithMinPropertiesAndOmitEmptyTag is a struct field with a minimum number of properties.
+	// structWithMinPropertiesAndOmitEmptyAndOmitZero is a struct field with a minimum number of properties and has both omitzero and omitemtpy tag.
 	// +kubebuilder:validation:MinProperties=1
 	// +optional
-	StructWithMinPropertiesAndOmitEmptyTag B `json:"structWithMinPropertiesAndOmitEmptyTag,omitempty,omitzero"`
+	StructWithMinPropertiesAndOmitEmptyAndOmitZero B `json:"structWithMinPropertiesAndOmitEmptyAndOmitZero,omitempty,omitzero"`
+
+	// structWithOnlyOmitZeroTag is a struct field with a minimum number of properties and has only omitzero tag.
+	// +kubebuilder:validation:MinProperties=1
+	// +optional
+	StructWithOnlyOmitZeroTag B `json:"structWithOnlyOmitZeroTag,omitempty,omitzero"` // want "field StructWithOnlyOmitZeroTag is optional and should have the omitempty tag"
 
 	// structWithMinPropertiesOnStruct is a struct field with a minimum number of properties on the struct.
 	// +optional