run modernize

sivchari · sivchari · commit 38ed5cba2a45 · 2025-04-30T02:27:26.000+09:00
Signed-off-by: sivchari &lt;shibuuuu5@gmail.com&gt;
diff --git a/pkg/analysis/commentstart/analyzer.go b/pkg/analysis/commentstart/analyzer.go
@@ -40,7 +40,7 @@ var Analyzer = &analysis.Analyzer{
 	Requires: []*analysis.Analyzer{inspector.Analyzer},
 }
 
-func run(pass *analysis.Pass) (interface{}, error) {
+func run(pass *analysis.Pass) (any, error) {
 	inspect, ok := pass.ResultOf[inspector.Analyzer].(inspector.Inspector)
 	if !ok {
 		return nil, kalerrors.ErrCouldNotGetInspector
diff --git a/pkg/analysis/conditions/analyzer.go b/pkg/analysis/conditions/analyzer.go
@@ -86,7 +86,7 @@ func newAnalyzer(cfg config.ConditionsConfig) *analysis.Analyzer {
 	}
 }
 
-func (a *analyzer) run(pass *analysis.Pass) (interface{}, error) {
+func (a *analyzer) run(pass *analysis.Pass) (any, error) {
 	inspect, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
 	if !ok {
 		return nil, kalerrors.ErrCouldNotGetInspector
diff --git a/pkg/analysis/helpers/extractjsontags/analyzer.go b/pkg/analysis/helpers/extractjsontags/analyzer.go
@@ -64,7 +64,7 @@ var Analyzer = &analysis.Analyzer{
 	ResultType: reflect.TypeOf(newStructFieldTags()),
 }
 
-func run(pass *analysis.Pass) (interface{}, error) {
+func run(pass *analysis.Pass) (any, error) {
 	inspect, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
 	if !ok {
 		return nil, kalerrors.ErrCouldNotGetInspector
diff --git a/pkg/analysis/helpers/inspector/analyzer.go b/pkg/analysis/helpers/inspector/analyzer.go
@@ -40,7 +40,7 @@ var Analyzer = &analysis.Analyzer{
 	ResultType: reflect.TypeOf(newInspector(nil, nil, nil)),
 }
 
-func run(pass *analysis.Pass) (interface{}, error) {
+func run(pass *analysis.Pass) (any, error) {
 	astinspector, ok := pass.ResultOf[inspect.Analyzer].(*astinspector.Inspector)
 	if !ok {
 		return nil, kalerrors.ErrCouldNotGetInspector
diff --git a/pkg/analysis/helpers/inspector/analyzer_test.go b/pkg/analysis/helpers/inspector/analyzer_test.go
@@ -42,7 +42,7 @@ var testAnalyzer = &analysis.Analyzer{
 	Requires: []*analysis.Analyzer{inspector.Analyzer},
 }
 
-func run(pass *analysis.Pass) (interface{}, error) {
+func run(pass *analysis.Pass) (any, error) {
 	inspect, ok := pass.ResultOf[inspector.Analyzer].(inspector.Inspector)
 	if !ok {
 		return nil, errCouldNotGetInspector
diff --git a/pkg/analysis/helpers/markers/analyzer.go b/pkg/analysis/helpers/markers/analyzer.go
@@ -113,7 +113,7 @@ var Analyzer = &analysis.Analyzer{
 	ResultType: reflect.TypeOf(newMarkers()),
 }
 
-func run(pass *analysis.Pass) (interface{}, error) {
+func run(pass *analysis.Pass) (any, error) {
 	inspect, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
 	if !ok {
 		return nil, kalerrors.ErrCouldNotGetInspector
@@ -239,8 +239,8 @@ func extractExpressions(expressions string) map[string]string {
 
 	// split expression string on commas (,) to handle multiple expressions
 	// in a single marker
-	chainedExpressions := strings.Split(expressions, ",")
-	for _, chainedExpression := range chainedExpressions {
+	chainedExpressions := strings.SplitSeq(expressions, ",")
+	for chainedExpression := range chainedExpressions {
 		exps := strings.SplitN(chainedExpression, "=", 2)
 		if len(exps) < 2 {
 			continue
diff --git a/pkg/analysis/integers/analyzer.go b/pkg/analysis/integers/analyzer.go
@@ -36,7 +36,7 @@ var Analyzer = &analysis.Analyzer{
 	Requires: []*analysis.Analyzer{inspect.Analyzer},
 }
 
-func run(pass *analysis.Pass) (interface{}, error) {
+func run(pass *analysis.Pass) (any, error) {
 	inspect, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
 	if !ok {
 		return nil, kalerrors.ErrCouldNotGetInspector
diff --git a/pkg/analysis/jsontags/analyzer.go b/pkg/analysis/jsontags/analyzer.go
@@ -61,7 +61,7 @@ func newAnalyzer(cfg config.JSONTagsConfig) (*analysis.Analyzer, error) {
 	}, nil
 }
 
-func (a *analyzer) run(pass *analysis.Pass) (interface{}, error) {
+func (a *analyzer) run(pass *analysis.Pass) (any, error) {
 	inspect, ok := pass.ResultOf[inspector.Analyzer].(inspector.Inspector)
 	if !ok {
 		return nil, kalerrors.ErrCouldNotGetInspector
diff --git a/pkg/analysis/maxlength/analyzer.go b/pkg/analysis/maxlength/analyzer.go
@@ -49,7 +49,7 @@ var Analyzer = &analysis.Analyzer{
 	Requires: []*analysis.Analyzer{inspector.Analyzer},
 }
 
-func run(pass *analysis.Pass) (interface{}, error) {
+func run(pass *analysis.Pass) (any, error) {
 	inspect, ok := pass.ResultOf[inspector.Analyzer].(inspector.Inspector)
 	if !ok {
 		return nil, kalerrors.ErrCouldNotGetInspector
diff --git a/pkg/analysis/nobools/analyzer.go b/pkg/analysis/nobools/analyzer.go
@@ -36,7 +36,7 @@ var Analyzer = &analysis.Analyzer{
 	Requires: []*analysis.Analyzer{inspect.Analyzer},
 }
 
-func run(pass *analysis.Pass) (interface{}, error) {
+func run(pass *analysis.Pass) (any, error) {
 	inspect, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
 	if !ok {
 		return nil, kalerrors.ErrCouldNotGetInspector
diff --git a/pkg/analysis/nofloats/analyzer.go b/pkg/analysis/nofloats/analyzer.go
@@ -36,7 +36,7 @@ var Analyzer = &analysis.Analyzer{
 	Requires: []*analysis.Analyzer{inspect.Analyzer},
 }
 
-func run(pass *analysis.Pass) (interface{}, error) {
+func run(pass *analysis.Pass) (any, error) {
 	inspect, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
 	if !ok {
 		return nil, kalerrors.ErrCouldNotGetInspector
diff --git a/pkg/analysis/nophase/analyzer.go b/pkg/analysis/nophase/analyzer.go
@@ -38,7 +38,7 @@ var Analyzer = &analysis.Analyzer{
 	Requires: []*analysis.Analyzer{inspect.Analyzer, extractjsontags.Analyzer},
 }
 
-func run(pass *analysis.Pass) (interface{}, error) {
+func run(pass *analysis.Pass) (any, error) {
 	inspect, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
 	if !ok {
 		return nil, kalerrors.ErrCouldNotGetInspector
diff --git a/pkg/analysis/optionalorrequired/analyzer.go b/pkg/analysis/optionalorrequired/analyzer.go
@@ -92,7 +92,7 @@ func newAnalyzer(cfg config.OptionalOrRequiredConfig) *analysis.Analyzer {
 	}
 }
 
-func (a *analyzer) run(pass *analysis.Pass) (interface{}, error) {
+func (a *analyzer) run(pass *analysis.Pass) (any, error) {
 	inspect, ok := pass.ResultOf[inspector.Analyzer].(inspector.Inspector)
 	if !ok {
 		return nil, kalerrors.ErrCouldNotGetInspector
@@ -167,7 +167,7 @@ func reportShouldReplaceSecondaryMarker(field *ast.Field, marker []markers.Marke
 			textEdits[i] = analysis.TextEdit{
 				Pos:     m.Pos,
 				End:     m.End,
-				NewText: []byte(fmt.Sprintf("// +%s", primaryMarker)),
+				NewText: fmt.Appendf(nil, "// +%s", primaryMarker),
 			}
 
 			continue
diff --git a/pkg/analysis/requiredfields/analyzer.go b/pkg/analysis/requiredfields/analyzer.go
@@ -59,7 +59,7 @@ func newAnalyzer(cfg config.RequiredFieldsConfig) *analysis.Analyzer {
 	}
 }
 
-func (a *analyzer) run(pass *analysis.Pass) (interface{}, error) {
+func (a *analyzer) run(pass *analysis.Pass) (any, error) {
 	inspect, ok := pass.ResultOf[inspector.Analyzer].(inspector.Inspector)
 	if !ok {
 		return nil, kalerrors.ErrCouldNotGetInspector
diff --git a/pkg/analysis/statussubresource/analyzer.go b/pkg/analysis/statussubresource/analyzer.go
@@ -54,7 +54,7 @@ func newAnalyzer() *analysis.Analyzer {
 	}
 }
 
-func (a *analyzer) run(pass *analysis.Pass) (interface{}, error) {
+func (a *analyzer) run(pass *analysis.Pass) (any, error) {
 	inspect, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
 	if !ok {
 		return nil, kalerrors.ErrCouldNotGetInspector
diff --git a/pkg/analysis/utils/type_check_test.go b/pkg/analysis/utils/type_check_test.go
@@ -41,7 +41,7 @@ func testAnalyzer() *analysis.Analyzer {
 		Name:     "test",
 		Doc:      "test",
 		Requires: []*analysis.Analyzer{inspect.Analyzer},
-		Run: func(pass *analysis.Pass) (interface{}, error) {
+		Run: func(pass *analysis.Pass) (any, error) {
 			inspect, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
 			if !ok {
 				return nil, errCouldNotGetInspector

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ var Analyzer = &analysis.Analyzer{`
`40`	`40`	`Requires: []*analysis.Analyzer{inspector.Analyzer},`
`41`	`41`	`}`
`42`	`42`
`43`		`-func run(pass *analysis.Pass) (interface{}, error) {`
	`43`	`+func run(pass *analysis.Pass) (any, error) {`
`44`	`44`	`inspect, ok := pass.ResultOf[inspector.Analyzer].(inspector.Inspector)`
`45`	`45`	`if !ok {`
`46`	`46`	`return nil, kalerrors.ErrCouldNotGetInspector`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ func newAnalyzer(cfg config.ConditionsConfig) *analysis.Analyzer {`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`
`89`		`-func (a analyzer) run(pass analysis.Pass) (interface{}, error) {`
	`89`	`+func (a analyzer) run(pass analysis.Pass) (any, error) {`
`90`	`90`	`inspect, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)`
`91`	`91`	`if !ok {`
`92`	`92`	`return nil, kalerrors.ErrCouldNotGetInspector`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ var Analyzer = &analysis.Analyzer{`
`64`	`64`	`ResultType: reflect.TypeOf(newStructFieldTags()),`
`65`	`65`	`}`
`66`	`66`
`67`		`-func run(pass *analysis.Pass) (interface{}, error) {`
	`67`	`+func run(pass *analysis.Pass) (any, error) {`
`68`	`68`	`inspect, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)`
`69`	`69`	`if !ok {`
`70`	`70`	`return nil, kalerrors.ErrCouldNotGetInspector`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ var testAnalyzer = &analysis.Analyzer{`
`42`	`42`	`Requires: []*analysis.Analyzer{inspector.Analyzer},`
`43`	`43`	`}`
`44`	`44`
`45`		`-func run(pass *analysis.Pass) (interface{}, error) {`
	`45`	`+func run(pass *analysis.Pass) (any, error) {`
`46`	`46`	`inspect, ok := pass.ResultOf[inspector.Analyzer].(inspector.Inspector)`
`47`	`47`	`if !ok {`
`48`	`48`	`return nil, errCouldNotGetInspector`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ var Analyzer = &analysis.Analyzer{`
`36`	`36`	`Requires: []*analysis.Analyzer{inspect.Analyzer},`
`37`	`37`	`}`
`38`	`38`
`39`		`-func run(pass *analysis.Pass) (interface{}, error) {`
	`39`	`+func run(pass *analysis.Pass) (any, error) {`
`40`	`40`	`inspect, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)`
`41`	`41`	`if !ok {`
`42`	`42`	`return nil, kalerrors.ErrCouldNotGetInspector`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ func newAnalyzer(cfg config.JSONTagsConfig) (*analysis.Analyzer, error) {`
`61`	`61`	`}, nil`
`62`	`62`	`}`
`63`	`63`
`64`		`-func (a analyzer) run(pass analysis.Pass) (interface{}, error) {`
	`64`	`+func (a analyzer) run(pass analysis.Pass) (any, error) {`
`65`	`65`	`inspect, ok := pass.ResultOf[inspector.Analyzer].(inspector.Inspector)`
`66`	`66`	`if !ok {`
`67`	`67`	`return nil, kalerrors.ErrCouldNotGetInspector`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ var Analyzer = &analysis.Analyzer{`
`49`	`49`	`Requires: []*analysis.Analyzer{inspector.Analyzer},`
`50`	`50`	`}`
`51`	`51`
`52`		`-func run(pass *analysis.Pass) (interface{}, error) {`
	`52`	`+func run(pass *analysis.Pass) (any, error) {`
`53`	`53`	`inspect, ok := pass.ResultOf[inspector.Analyzer].(inspector.Inspector)`
`54`	`54`	`if !ok {`
`55`	`55`	`return nil, kalerrors.ErrCouldNotGetInspector`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ var Analyzer = &analysis.Analyzer{`
`38`	`38`	`Requires: []*analysis.Analyzer{inspect.Analyzer, extractjsontags.Analyzer},`
`39`	`39`	`}`
`40`	`40`
`41`		`-func run(pass *analysis.Pass) (interface{}, error) {`
	`41`	`+func run(pass *analysis.Pass) (any, error) {`
`42`	`42`	`inspect, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)`
`43`	`43`	`if !ok {`
`44`	`44`	`return nil, kalerrors.ErrCouldNotGetInspector`
Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ func newAnalyzer(cfg config.OptionalOrRequiredConfig) *analysis.Analyzer {`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`
`95`		`-func (a analyzer) run(pass analysis.Pass) (interface{}, error) {`
	`95`	`+func (a analyzer) run(pass analysis.Pass) (any, error) {`
`96`	`96`	`inspect, ok := pass.ResultOf[inspector.Analyzer].(inspector.Inspector)`
`97`	`97`	`if !ok {`
`98`	`98`	`return nil, kalerrors.ErrCouldNotGetInspector`
`@@ -167,7 +167,7 @@ func reportShouldReplaceSecondaryMarker(field *ast.Field, marker []markers.Marke`
`167`	`167`	`textEdits[i] = analysis.TextEdit{`
`168`	`168`	`Pos: m.Pos,`
`169`	`169`	`End: m.End,`
`170`		`- NewText: []byte(fmt.Sprintf("// +%s", primaryMarker)),`
	`170`	`+ NewText: fmt.Appendf(nil, "// +%s", primaryMarker),`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`continue`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ func newAnalyzer(cfg config.RequiredFieldsConfig) *analysis.Analyzer {`
`59`	`59`	`}`
`60`	`60`	`}`
`61`	`61`
`62`		`-func (a analyzer) run(pass analysis.Pass) (interface{}, error) {`
	`62`	`+func (a analyzer) run(pass analysis.Pass) (any, error) {`
`63`	`63`	`inspect, ok := pass.ResultOf[inspector.Analyzer].(inspector.Inspector)`
`64`	`64`	`if !ok {`
`65`	`65`	`return nil, kalerrors.ErrCouldNotGetInspector`