Replies: 4 comments 1 reply
-
Are options 1, 2, and 3 all breaking changes for our early adopters? I want to make sure I'm understanding that correctly. To add some context, in our conformance tests (specifically #911), we're looking at these scenarios:
Right now, both the (small nit in the discussion title @robscott, it should be |
Beta Was this translation helpful? Give feedback.
-
+1 on option 5 |
Beta Was this translation helpful? Give feedback.
-
xref kubernetes-sigs/gateway-api#3840 to clarify |
Beta Was this translation helpful? Give feedback.
-
+1 on option 5. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
The relevant part of the Gateway API Spec leaves this rather ambiguous.
I think we have 3 options here:
HTTPRoute.BackendRef.Port
must equalInferencePool.TargetPortNumber
HTTPRoute.BackendRef.Port
must not be set when the target is InferencePoolHTTPRoute.BackendRef.Port
must equalInferencePool.TargetPortNumber
when set, but can be left unspecifiedHTTPRoute.BackendRef.Port
is always ignored when the target is InferencePoolHTTPRoute.BackendRef.Port
is set and an InferencePool is targeted, saying that the port will be ignored. Gateway API v1.4 includes validation that prevents BackendRef.Port from being set when the target is an InferencePool.IMO, 4 is a non-starter as it would result in a great deal of confusion. 1 and 2 are the easiest to implement, and 3 may be the best UX.
Any opinions @danehans, @LiorLieberman, @spencerhance?
Beta Was this translation helpful? Give feedback.
All reactions