Skip to content

Commit d9cc96b

Browse files
committed
Verify r.Others.startQueue in runnables test cases.
1 parent 66e3be4 commit d9cc96b

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

pkg/manager/runnable_group_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,23 @@ var _ = Describe("runnables", func() {
2727
r := newRunnables(defaultBaseContext, errCh)
2828
Expect(r.Add(server)).To(Succeed())
2929
Expect(r.HTTPServers.startQueue).To(HaveLen(1))
30+
Expect(r.Others.startQueue).To(BeEmpty())
3031
})
3132

3233
It("should add caches to the appropriate group", func() {
3334
cache := &cacheProvider{cache: &informertest.FakeInformers{Error: fmt.Errorf("expected error")}}
3435
r := newRunnables(defaultBaseContext, errCh)
3536
Expect(r.Add(cache)).To(Succeed())
3637
Expect(r.Caches.startQueue).To(HaveLen(1))
38+
Expect(r.Others.startQueue).To(BeEmpty())
3739
})
3840

3941
It("should add webhooks to the appropriate group", func() {
4042
webhook := webhook.NewServer(webhook.Options{})
4143
r := newRunnables(defaultBaseContext, errCh)
4244
Expect(r.Add(webhook)).To(Succeed())
4345
Expect(r.Webhooks.startQueue).To(HaveLen(1))
46+
Expect(r.Others.startQueue).To(BeEmpty())
4447
})
4548

4649
It("should add any runnable to the leader election group", func() {
@@ -52,6 +55,7 @@ var _ = Describe("runnables", func() {
5255
r := newRunnables(defaultBaseContext, errCh)
5356
Expect(r.Add(runnable)).To(Succeed())
5457
Expect(r.LeaderElection.startQueue).To(HaveLen(1))
58+
Expect(r.Others.startQueue).To(BeEmpty())
5559
})
5660

5761
It("should add WarmupRunnable to the Warmup and LeaderElection group", func() {
@@ -69,6 +73,7 @@ var _ = Describe("runnables", func() {
6973
Expect(r.Add(warmupRunnable)).To(Succeed())
7074
Expect(r.Warmup.startQueue).To(HaveLen(1))
7175
Expect(r.LeaderElection.startQueue).To(HaveLen(1))
76+
Expect(r.Others.startQueue).To(BeEmpty())
7277
})
7378

7479
It("should add WarmupRunnable that doesn't needs leader election to warmup group only", func() {
@@ -90,6 +95,7 @@ var _ = Describe("runnables", func() {
9095

9196
Expect(r.Warmup.startQueue).To(HaveLen(1))
9297
Expect(r.LeaderElection.startQueue).To(BeEmpty())
98+
Expect(r.Others.startQueue).To(HaveLen(1))
9399
})
94100

95101
It("should add WarmupRunnable that needs leader election to Warmup and LeaderElection group, not Others", func() {

0 commit comments

Comments
 (0)