Make tests run under the race detector

This fixes up a few tests that didn't run under the race detector.  The
reasons ranged from silly variable re-use issues that weren't required
to actual bugs in our tests that we just probably accidentally didn't
hit.

This also enables the race detector in hack/test-all.sh

Author: DirectXMan12

hack/test-all.sh

@@ -22,6 +22,7 @@ setup_envs
 
 header_text "running go test"
 
+# TODO(directxman12): enable the race detector once the LeaderElector race condition is resolved in client-go
 go test ${MOD_OPT} ./... -parallel 4
 
 header_text "running coverage"

pkg/cache/cache_test.go

@@ -115,10 +115,11 @@ func CacheTest(createCacheFunc func(config *rest.Config, opts cache.Options) (ca
 			informerCache, err = createCacheFunc(cfg, cache.Options{})
 			Expect(err).NotTo(HaveOccurred())
 			By("running the cache and waiting for it to sync")
-			go func() {
+			// pass as an arg so that we don't race between close and re-assign
+			go func(stopCh chan struct{}) {
 				defer GinkgoRecover()
-				Expect(informerCache.Start(stop)).To(Succeed())
-			}()
+				Expect(informerCache.Start(stopCh)).To(Succeed())
+			}(stop)
 			Expect(informerCache.WaitForCacheSync(stop)).To(BeTrue())
 		})