Skip to content

Commit 3f5e5ec

Browse files
committed
🌱 Validate that unstructued objects don't require scheme registriation
If someone is interacting with objects through unstructured, we generally do not expect that to require any sort of registration in the scheme. It look like we never had any tests for this, this change adds them.
1 parent 9024933 commit 3f5e5ec

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

pkg/client/client_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1036,7 +1036,7 @@ U5wwSivyi7vmegHKmblOzNVKA5qPO8zWzqBC
10361036

10371037
Context("with unstructured objects", func() {
10381038
It("should be able to read the Scale subresource", func() {
1039-
cl, err := client.New(cfg, client.Options{})
1039+
cl, err := client.New(cfg, client.Options{Scheme: runtime.NewScheme()})
10401040
Expect(err).NotTo(HaveOccurred())
10411041
Expect(cl).NotTo(BeNil())
10421042

@@ -1061,7 +1061,7 @@ U5wwSivyi7vmegHKmblOzNVKA5qPO8zWzqBC
10611061
Expect(int32(val)).To(Equal(*dep.Spec.Replicas))
10621062
})
10631063
It("should be able to create ServiceAccount tokens", func() {
1064-
cl, err := client.New(cfg, client.Options{})
1064+
cl, err := client.New(cfg, client.Options{Scheme: runtime.NewScheme()})
10651065
Expect(err).NotTo(HaveOccurred())
10661066
Expect(cl).NotTo(BeNil())
10671067

@@ -1089,7 +1089,7 @@ U5wwSivyi7vmegHKmblOzNVKA5qPO8zWzqBC
10891089
})
10901090

10911091
It("should be able to create Pod evictions", func() {
1092-
cl, err := client.New(cfg, client.Options{})
1092+
cl, err := client.New(cfg, client.Options{Scheme: runtime.NewScheme()})
10931093
Expect(err).NotTo(HaveOccurred())
10941094
Expect(cl).NotTo(BeNil())
10951095

@@ -1122,7 +1122,7 @@ U5wwSivyi7vmegHKmblOzNVKA5qPO8zWzqBC
11221122
})
11231123

11241124
It("should be able to create Pod bindings", func() {
1125-
cl, err := client.New(cfg, client.Options{})
1125+
cl, err := client.New(cfg, client.Options{Scheme: runtime.NewScheme()})
11261126
Expect(err).NotTo(HaveOccurred())
11271127
Expect(cl).NotTo(BeNil())
11281128

@@ -1157,7 +1157,7 @@ U5wwSivyi7vmegHKmblOzNVKA5qPO8zWzqBC
11571157
})
11581158

11591159
It("should be able to approve CSRs", func() {
1160-
cl, err := client.New(cfg, client.Options{})
1160+
cl, err := client.New(cfg, client.Options{Scheme: runtime.NewScheme()})
11611161
Expect(err).NotTo(HaveOccurred())
11621162
Expect(cl).NotTo(BeNil())
11631163

@@ -1188,7 +1188,7 @@ U5wwSivyi7vmegHKmblOzNVKA5qPO8zWzqBC
11881188
})
11891189

11901190
It("should be able to approve CSRs using Patch", func() {
1191-
cl, err := client.New(cfg, client.Options{})
1191+
cl, err := client.New(cfg, client.Options{Scheme: runtime.NewScheme()})
11921192
Expect(err).NotTo(HaveOccurred())
11931193
Expect(cl).NotTo(BeNil())
11941194

@@ -1220,7 +1220,7 @@ U5wwSivyi7vmegHKmblOzNVKA5qPO8zWzqBC
12201220
})
12211221

12221222
It("should be able to update the scale subresource", func() {
1223-
cl, err := client.New(cfg, client.Options{})
1223+
cl, err := client.New(cfg, client.Options{Scheme: runtime.NewScheme()})
12241224
Expect(err).NotTo(HaveOccurred())
12251225
Expect(cl).NotTo(BeNil())
12261226

@@ -1250,7 +1250,7 @@ U5wwSivyi7vmegHKmblOzNVKA5qPO8zWzqBC
12501250
})
12511251

12521252
It("should be able to patch the scale subresource", func() {
1253-
cl, err := client.New(cfg, client.Options{})
1253+
cl, err := client.New(cfg, client.Options{Scheme: runtime.NewScheme()})
12541254
Expect(err).NotTo(HaveOccurred())
12551255
Expect(cl).NotTo(BeNil())
12561256

0 commit comments

Comments
 (0)