Skip to content

Commit 2366fb2

Browse files
authored
Merge pull request #3150 from sbueringer/pr-fix-test-race
🐛 Fix race in logger test
2 parents 4b686fa + 6f0283f commit 2366fb2

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

pkg/manager/manager_test.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1092,9 +1092,14 @@ var _ = Describe("manger.Manager", func() {
10921092
msg := "controller log message"
10931093
m.GetControllerOptions().Logger.Info(msg)
10941094

1095-
Expect(messages).To(ContainElement(
1096-
ContainSubstring(msg),
1097-
))
1095+
Eventually(func(g Gomega) {
1096+
lock.Lock()
1097+
defer lock.Unlock()
1098+
1099+
g.Expect(messages).To(ContainElement(
1100+
ContainSubstring(msg),
1101+
))
1102+
}).Should(Succeed())
10981103
})
10991104

11001105
It("should return both runnables and stop errors when both error", func() {

0 commit comments

Comments
 (0)