Skip to content

Commit 02c4ef4

Browse files
authored
Merge pull request #3006 from alvaroaleman/start-comment
🌱 Source.Start(): Use errgroup without context
2 parents 63a3800 + 6d6cb80 commit 02c4ef4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/internal/controller/controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ func (c *Controller[request]) Start(ctx context.Context) error {
173173
// NB(directxman12): launch the sources *before* trying to wait for the
174174
// caches to sync so that they have a chance to register their intendeded
175175
// caches.
176-
errGroup, _ := errgroup.WithContext(ctx)
176+
errGroup := &errgroup.Group{}
177177
for _, watch := range c.startWatches {
178178
log := c.LogConstructor(nil).WithValues("source", fmt.Sprintf("%s", watch))
179179
didStartSyncingSource := &atomic.Bool{}

0 commit comments

Comments
 (0)