Merge pull request #10672 from sbueringer/pr-fix-indexing

k8s-ci-robot · web-flow · commit ec67e1a4fa96 · 2024-05-24T03:22:20.000-07:00
🐛 Fix indexing in ClusterClass webhook MHC validation
diff --git a/internal/webhooks/clusterclass.go b/internal/webhooks/clusterclass.go
@@ -411,7 +411,7 @@ func validateMachineHealthCheckClasses(clusterClass *clusterv1.ClusterClass) fie
 		if md.MachineHealthCheck == nil {
 			continue
 		}
-		fldPath := field.NewPath("spec", "workers", "machineDeployments", "machineHealthCheck").Index(i)
+		fldPath := field.NewPath("spec", "workers", "machineDeployments").Index(i).Child("machineHealthCheck")
 
 		allErrs = append(allErrs, validateMachineHealthCheckClass(fldPath, clusterClass.Namespace, md.MachineHealthCheck)...)
 	}

Original file line number	Diff line number	Diff line change
`@@ -411,7 +411,7 @@ func validateMachineHealthCheckClasses(clusterClass *clusterv1.ClusterClass) fie`
`411`	`411`	`if md.MachineHealthCheck == nil {`
`412`	`412`	`continue`
`413`	`413`	`}`
`414`		`- fldPath := field.NewPath("spec", "workers", "machineDeployments", "machineHealthCheck").Index(i)`
	`414`	`+ fldPath := field.NewPath("spec", "workers", "machineDeployments").Index(i).Child("machineHealthCheck")`
`415`	`415`
`416`	`416`	`allErrs = append(allErrs, validateMachineHealthCheckClass(fldPath, clusterClass.Namespace, md.MachineHealthCheck)...)`
`417`	`417`	`}`