Add maxItems to all condition fields

Signed-off-by: Stefan Büringer buringerst@vmware.com

Author: sbueringer

config/crd/bases/addons.cluster.x-k8s.io_clusterresourcesets.yaml

@@ -291,6 +291,7 @@ type MachineStatus struct {
     // +optional
     // +listType=map
     // +listMapKey=type
+    // +kubebuilder:validation:MaxItems=32
     Conditions []metav1.Condition `json:"conditions,omitempty"`
 
     // Other fields...
@@ -488,6 +489,7 @@ type MachineSetStatus struct {
     // +optional
     // +listType=map
     // +listMapKey=type
+    // +kubebuilder:validation:MaxItems=32
     Conditions []metav1.Condition `json:"conditions,omitempty"`
 
     // Other fields...
@@ -616,6 +618,7 @@ type MachineDeploymentStatus struct {
     // +optional
     // +listType=map
     // +listMapKey=type
+    // +kubebuilder:validation:MaxItems=32
     Conditions []metav1.Condition `json:"conditions,omitempty"`
 
     // Other fields...
@@ -730,6 +733,7 @@ type ClusterStatus struct {
     // +optional
     // +listType=map
     // +listMapKey=type
+    // +kubebuilder:validation:MaxItems=32
     Conditions []metav1.Condition `json:"conditions,omitempty"`
 
     // ControlPlane groups all the observations about Cluster's ControlPlane current state.
@@ -981,6 +985,7 @@ type KubeadmControlPlaneStatus struct {
     // +optional
     // +listType=map
     // +listMapKey=type
+    // +kubebuilder:validation:MaxItems=32
     Conditions []metav1.Condition `json:"conditions,omitempty"`
 
     // Other fields...
@@ -1100,6 +1105,7 @@ type MachinePoolStatus struct {
     // +optional
     // +listType=map
     // +listMapKey=type
+    // +kubebuilder:validation:MaxItems=32
     Conditions []metav1.Condition `json:"conditions,omitempty"`
 
     // Other fields...

config/crd/bases/cluster.x-k8s.io_machinepools.yaml

@@ -115,6 +115,7 @@ type ClusterResourceSetV1Beta2Status struct {
 	// +optional
 	// +listType=map
 	// +listMapKey=type
+	// +kubebuilder:validation:MaxItems=32
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
 }
 

docs/proposals/20240916-improve-status-in-CAPI-resources.md

@@ -137,6 +137,7 @@ type MachinePoolV1Beta2Status struct {
 	// +optional
 	// +listType=map
 	// +listMapKey=type
+	// +kubebuilder:validation:MaxItems=32
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
 
 	// readyReplicas is the number of ready replicas for this MachinePool. A machine is considered ready when Machine's Ready condition is true.

exp/addons/api/v1beta1/clusterresourceset_types.go

@@ -156,6 +156,7 @@ spec:
                       - status
                       - type
                       type: object
+                    maxItems: 32
                     type: array
                     x-kubernetes-list-map-keys:
                     - type

exp/api/v1beta1/machinepool_types.go

@@ -105,6 +105,7 @@ spec:
                   - status
                   - type
                   type: object
+                maxItems: 32
                 type: array
                 x-kubernetes-list-map-keys:
                 - type

internal/test/builder/crd/test.cluster.x-k8s.io_phase1obj.yaml

@@ -104,6 +104,7 @@ spec:
                   - status
                   - type
                   type: object
+                maxItems: 32
                 type: array
                 x-kubernetes-list-map-keys:
                 - type

internal/test/builder/crd/test.cluster.x-k8s.io_phase2obj.yaml

@@ -138,6 +138,7 @@ type Phase1ObjStatusV1Beta2 struct {
 	// +optional
 	// +listType=map
 	// +listMapKey=type
+	// +kubebuilder:validation:MaxItems=32
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
 }
 
@@ -201,6 +202,7 @@ type Phase2ObjStatus struct {
 	// +optional
 	// +listType=map
 	// +listMapKey=type
+	// +kubebuilder:validation:MaxItems=32
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
 
 	// +optional
@@ -284,6 +286,7 @@ type Phase3ObjStatus struct {
 	// +optional
 	// +listType=map
 	// +listMapKey=type
+	// +kubebuilder:validation:MaxItems=32
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
 }