Merge pull request #11374 from Nordix/healthcheck-fix/adil

🌱 Fixing TestClusterCacheHealthCheck flake

Author: k8s-ci-robot

controllers/remote/cluster_cache_healthcheck_test.go

@@ -19,6 +19,7 @@ package remote
 import (
 	"context"
 	"fmt"
+	"math"
 	"net"
 	"testing"
 	"time"
@@ -158,7 +159,8 @@ func TestClusterCacheHealthCheck(t *testing.T) {
 			ns := setup(t, g)
 			defer teardown(t, g, ns)
 			// Create a context with a timeout to cancel the healthcheck after some time
-			ctx, cancel := context.WithTimeout(ctx, time.Second)
+			contextTimeout := time.Second
+			ctx, cancel := context.WithTimeout(ctx, contextTimeout)
 			defer cancel()
 			// Delete the cluster accessor and lock the cluster to simulate creation of a new cluster accessor
 			cct.deleteAccessor(ctx, testClusterKey)
@@ -177,8 +179,9 @@ func TestClusterCacheHealthCheck(t *testing.T) {
 				path:               "/",
 			})
 			timeElapsedForHealthCheck := time.Since(startHealthCheck)
+			timeElapsedForHealthCheckRounded := int(math.Round(timeElapsedForHealthCheck.Seconds()))
 			// If the duration is shorter than the timeout, we know that the healthcheck wasn't requeued properly.
-			g.Expect(timeElapsedForHealthCheck).Should(BeNumerically(">=", time.Second))
+			g.Expect(timeElapsedForHealthCheckRounded).Should(BeNumerically(">=", int(contextTimeout.Seconds())))
 			// The healthcheck should be aborted by the timout of the context
 			g.Expect(ctx.Done()).Should(BeClosed())
 		})