fix: lint

Signed-off-by: sivchari <shibuuuu5@gmail.com>

Author: sivchari

cmd/clusterctl/client/cluster/template.go

@@ -303,12 +303,12 @@ func getGitHubClient(ctx context.Context, configVariablesClient config.Variables
 	return github.NewClient(authenticatingHTTPClient), nil
 }
 
-var RateLimitError = errors.New("rate limit for github api has been reached. Please wait one hour or get a personal API token and assign it to the GITHUB_TOKEN environment variable")
+var errRateLimit = errors.New("rate limit for github api has been reached. Please wait one hour or get a personal API token and assign it to the GITHUB_TOKEN environment variable")
 
 // handleGithubErr wraps error messages.
 func handleGithubErr(err error, message string, args ...interface{}) error {
 	if _, ok := err.(*github.RateLimitError); ok {
-		return RateLimitError
+		return errRateLimit
 	}
 	return fmt.Errorf("%s: %w", fmt.Sprintf(message, args...), err)
 }

cmd/clusterctl/client/cluster/template_test.go

@@ -542,7 +542,7 @@ func Test_handleGithubErr(t *testing.T) {
 			},
 			message: "",
 			args:    nil,
-			want:    RateLimitError,
+			want:    errRateLimit,
 		},
 	}
 	for _, tt := range tests {

controlplane/kubeadm/internal/controllers/controller.go

@@ -225,7 +225,11 @@ func (r *KubeadmControlPlaneReconciler) Reconcile(ctx context.Context, req ctrl.
 	return r.reconcile(ctx, controlPlane)
 }
 
-func (r *KubeadmControlPlaneReconciler) deferPatch(ctx context.Context, kcp *controlplanev1.KubeadmControlPlane, controlPlane *internal.ControlPlane, patchHelper *patch.Helper) (res ctrl.Result, reterr error) {
+func (r *KubeadmControlPlaneReconciler) deferPatch(ctx context.Context, kcp *controlplanev1.KubeadmControlPlane, controlPlane *internal.ControlPlane, patchHelper *patch.Helper) (ctrl.Result, error) {
+	var (
+		res    ctrl.Result
+		reterr error
+	)
 	log := ctrl.LoggerFrom(ctx)
 	// Always attempt to update status.
 	if err := r.updateStatus(ctx, controlPlane); err != nil {
@@ -268,7 +272,8 @@ func (r *KubeadmControlPlaneReconciler) deferPatch(ctx context.Context, kcp *con
 			res = ctrl.Result{RequeueAfter: 20 * time.Second}
 		}
 	}
-	return
+
+	return res, reterr
 }
 
 // initControlPlaneScope initializes the control plane scope; this includes also checking for orphan machines and