fix review findings

Signed-off-by: sivchari <shibuuuu5@gmail.com>

Author: sivchari

test/e2e/data/infrastructure-docker/main/bases/cluster-with-topology.yaml

@@ -15,6 +15,7 @@ spec:
   topology:
     classRef:
       name: "quick-start"
+      namespace: '${CLUSTER_CLASS_NAMESPACE:-""}'
     version: "${KUBERNETES_VERSION}"
     controlPlane:
       metadata:

test/e2e/data/infrastructure-docker/main/cluster-template-kcp-pre-drain/cluster.yaml

@@ -7,7 +7,6 @@ spec:
   topology:
     classRef:
       name: quick-start
-    version: "${KUBERNETES_VERSION}"
     controlPlane:
       metadata:
         annotations:

test/e2e/data/infrastructure-docker/main/cluster-template-topology-dualstack-ipv4-primary/cluster.yaml

@@ -7,7 +7,6 @@ spec:
   topology:
     classRef:
       name: quick-start
-    version: "${KUBERNETES_VERSION}"
     variables:
        - name: ipv6Primary
          value: false

test/e2e/data/infrastructure-docker/main/cluster-template-topology-dualstack-ipv6-primary/cluster.yaml

@@ -7,7 +7,6 @@ spec:
   topology:
     classRef:
       name: quick-start
-    version: "${KUBERNETES_VERSION}"
     variables:
        - name: ipv6Primary
          value: true

test/e2e/data/infrastructure-docker/main/cluster-template-topology-kcp-only/cluster-topology-class.yaml

@@ -0,0 +1,3 @@
+- op: add
+  path: /spec/topology/classRef/name
+  value: "quick-start-kcp-only"

test/e2e/data/infrastructure-docker/main/cluster-template-topology-kcp-only/kustomization.yaml

@@ -1,3 +1,9 @@
 resources:
   - ../cluster-template-topology-no-workers
 
+patches:
+- path: cluster-topology-class.yaml
+  target:
+    group: cluster.x-k8s.io
+    version: v1beta1
+    kind: Cluster

test/e2e/data/infrastructure-docker/main/cluster-template-upgrades-runtimesdk/cluster-runtimesdk.yaml

@@ -15,6 +15,7 @@ spec:
   topology:
     classRef:
       name: "quick-start-runtimesdk"
+      namespace: '${CLUSTER_CLASS_NAMESPACE:-""}'
     version: "${KUBERNETES_VERSION}"
     controlPlane:
       nodeDeletionTimeoutSeconds: 30

test/e2e/data/infrastructure-docker/main/clusterclass-quick-start.yaml

@@ -19,7 +19,6 @@ spec:
         kind: DockerMachineTemplate
         name: quick-start-control-plane
     machineHealthCheck:
-      maxUnhealthy: 100%
       unhealthyNodeConditions:
         - type: e2e.remediation.condition
           status: "False"
@@ -48,9 +47,6 @@ spec:
             apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
             kind: DockerMachineTemplate
             name: quick-start-default-worker-machinetemplate
-      machineHealthCheck:
-        maxUnhealthy: 100%
-        # We are intentionally not setting the 'unhealthyNodeConditions' here to test that the field is optional.
     machinePools:
     - class: default-worker
       template:

test/extension/handlers/topologymutation/handler.go

@@ -76,8 +76,6 @@ func NewExtensionHandlers() *ExtensionHandlers {
 			infrav1.GroupVersion,
 			bootstrapv1.GroupVersion,
 			bootstrapv1beta1.GroupVersion,
-			infraexpv1beta1.GroupVersion,
-			infraexpv1.GroupVersion,
 			controlplanev1beta1.GroupVersion,
 			controlplanev1.GroupVersion,
 		),

test/extension/handlers/topologymutation/handler_test.go

@@ -349,7 +349,7 @@ func TestHandler_GeneratePatches(t *testing.T) {
 				},
 				Items: []runtimehooksv1.GeneratePatchesResponseItem{
 					responseItem("1", `[
-						{"op":"add","path":"/spec","value":{"template": {"spec":{"rolloutStrategy": {"rollingUpdate":{"maxSurge":3}}}}}}
+{"op":"add","path":"/spec","value":{"template": {"spec":{"rolloutStrategy": {"rollingUpdate":{"maxSurge":3}}}}}}
 ]`),
 					responseItem("2", `[
 {"op":"add","path":"/spec/template/spec/customImage","value":"kindest/node:v1.23.0"}