Skip to content

Commit 9b82cec

Browse files
committed
fix kubelet extra args and naming strategy
Signed-off-by: sivchari <shibuuuu5@gmail.com>
1 parent 10834e4 commit 9b82cec

File tree

6 files changed

+39
-31
lines changed

6 files changed

+39
-31
lines changed

test/e2e/data/infrastructure-docker/main/cluster-template-ignition/ignition.yaml

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,27 @@ spec:
1010
# We have to set the criSocket to containerd as kubeadm defaults to docker runtime if both containerd and docker sockets are found
1111
criSocket: unix:///var/run/containerd/containerd.sock
1212
kubeletExtraArgs:
13-
eviction-hard: 'nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%'
14-
fail-swap-on: "false"
15-
cgroup-root: "/kubelet"
16-
runtime-cgroups: "/system.slice/containerd.service"
13+
- name: eviction-hard
14+
value: 'nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%'
15+
- name: fail-swap-on
16+
value: "false"
17+
- name: cgroup-root
18+
value: "/kubelet"
19+
- name: runtime-cgroups
20+
value: "/system.slice/containerd.service"
1721
joinConfiguration:
1822
nodeRegistration:
1923
# We have to set the criSocket to containerd as kubeadm defaults to docker runtime if both containerd and docker sockets are found
2024
criSocket: unix:///var/run/containerd/containerd.sock
2125
kubeletExtraArgs:
22-
eviction-hard: 'nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%'
23-
fail-swap-on: "false"
24-
cgroup-root: "/kubelet"
25-
runtime-cgroups: "/system.slice/containerd.service"
26+
- name: eviction-hard
27+
value: 'nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%'
28+
- name: fail-swap-on
29+
value: "false"
30+
- name: cgroup-root
31+
value: "/kubelet"
32+
- name: runtime-cgroups
33+
value: "/system.slice/containerd.service"
2634
---
2735
apiVersion: bootstrap.cluster.x-k8s.io/v1beta2
2836
kind: KubeadmConfigTemplate
@@ -47,7 +55,11 @@ spec:
4755
# We have to set the criSocket to containerd as kubeadm defaults to docker runtime if both containerd and docker sockets are found
4856
criSocket: unix:///var/run/containerd/containerd.sock
4957
kubeletExtraArgs:
50-
eviction-hard: 'nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%'
51-
fail-swap-on: "false"
52-
cgroup-root: "/kubelet"
53-
runtime-cgroups: "/system.slice/containerd.service"
58+
- name: eviction-hard
59+
value: 'nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%'
60+
- name: fail-swap-on
61+
value: "false"
62+
- name: cgroup-root
63+
value: "/kubelet"
64+
- name: runtime-cgroups
65+
value: "/system.slice/containerd.service"

test/e2e/data/infrastructure-docker/main/cluster-template-ipv6/kcp-ipv6.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ spec:
1515
bindPort: 6443
1616
nodeRegistration:
1717
kubeletExtraArgs:
18-
name: node-ip
19-
value: "::"
18+
- name: node-ip
19+
value: "::"
2020
joinConfiguration:
2121
nodeRegistration:
2222
kubeletExtraArgs:
23-
name: node-ip
24-
value: "::"
23+
- name: node-ip
24+
value: "::"

test/e2e/data/infrastructure-docker/main/cluster-template-ipv6/md-ipv6.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@ spec:
99
initConfiguration:
1010
nodeRegistration:
1111
kubeletExtraArgs:
12-
node-ip: "::"
12+
- name: node-ip
13+
value: "::"
1314
joinConfiguration:
1415
nodeRegistration:
1516
kubeletExtraArgs:
16-
node-ip: "::"
17+
- name: node-ip
18+
value: "::"

test/e2e/data/infrastructure-docker/main/clusterclass-in-memory.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ spec:
2727
nodeRegistration:
2828
criSocket: unix:///var/run/containerd/containerd.sock
2929
kubeletExtraArgs:
30-
name: eviction-hard
31-
value: nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%
30+
- name: eviction-hard
31+
value: nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%
3232
joinConfiguration:
3333
nodeRegistration:
3434
criSocket: unix:///var/run/containerd/containerd.sock
3535
kubeletExtraArgs:
36-
name: eviction-hard
37-
value: nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%
36+
- name: eviction-hard
37+
value: nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%
3838
---
3939
apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
4040
kind: DevMachineTemplate
@@ -99,8 +99,8 @@ spec:
9999
nodeRegistration:
100100
criSocket: unix:///var/run/containerd/containerd.sock
101101
kubeletExtraArgs:
102-
name: eviction-hard
103-
value: nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%
102+
- name: eviction-hard
103+
value: nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%
104104
---
105105
apiVersion: cluster.x-k8s.io/v1beta2
106106
kind: ClusterClass

test/e2e/data/infrastructure-docker/main/clusterclass-quick-start-runtimesdk.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ spec:
2020
apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
2121
kind: DockerClusterTemplate
2222
name: quick-start-cluster
23-
infrastructureNamingStrategy:
23+
namingStrategy:
2424
template: "{{ .cluster.name }}-infra-{{ .random }}"
2525
workers:
2626
machineDeployments:

test/e2e/data/infrastructure-docker/main/clusterclass-quick-start.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,6 @@ spec:
7878
default: kindest
7979
- name: etcdImageTag
8080
required: true
81-
# This metadata has just been added to verify that we can set metadata.
82-
metadata:
83-
labels:
84-
testLabelKey: testLabelValue
85-
annotations:
86-
testAnnotationKey: testAnnotationValue
8781
schema:
8882
openAPIV3Schema:
8983
type: string

0 commit comments

Comments
 (0)