test/framework: GetCAPIResources should warn on rbac issues

vincepri · vincepri · commit 8604dec928f2 · 2024-09-19T09:25:29.000-07:00
In restricted environments some resources might not be available for
retrieval; ensure to print a warning but not fail the operation.

Signed-off-by: Vince Prignano &lt;vince@prigna.com&gt;
diff --git a/test/framework/alltypes_helpers.go b/test/framework/alltypes_helpers.go
@@ -69,6 +69,10 @@ func GetCAPIResources(ctx context.Context, input GetCAPIResourcesInput) []*unstr
 			if apierrors.IsNotFound(err) {
 				continue
 			}
+			if apierrors.IsForbidden(err) {
+				fmt.Printf("Warning: failed to list %s resources due to a rbac issue: %v", typeList.GroupVersionKind(), err)
+				continue
+			}
 			Fail(fmt.Sprintf("failed to list %q resources: %v", typeList.GroupVersionKind(), err))
 		}
 		for i := range typeList.Items {

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,10 @@ func GetCAPIResources(ctx context.Context, input GetCAPIResourcesInput) []*unstr`
`69`	`69`	`if apierrors.IsNotFound(err) {`
`70`	`70`	`continue`
`71`	`71`	`}`
	`72`	`+ if apierrors.IsForbidden(err) {`
	`73`	`+ fmt.Printf("Warning: failed to list %s resources due to a rbac issue: %v", typeList.GroupVersionKind(), err)`
	`74`	`+ continue`
	`75`	`+ }`
`72`	`76`	`Fail(fmt.Sprintf("failed to list %q resources: %v", typeList.GroupVersionKind(), err))`
`73`	`77`	`}`
`74`	`78`	`for i := range typeList.Items {`