Skip to content

Commit 75c986d

Browse files
authored
Merge pull request #11245 from sbueringer/pr-use-todo-consistently
🌱 Use TODO instead of FIXME consistently
2 parents 377b79c + a7cfa99 commit 75c986d

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

cmd/clusterctl/client/cluster/mover.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -963,7 +963,7 @@ func (o *objectMover) createTargetObject(ctx context.Context, nodeToCreate *node
963963
// Rebuild the owner reference chain
964964
o.buildOwnerChain(obj, nodeToCreate)
965965

966-
// FIXME Workaround for https://github.com/kubernetes/kubernetes/issues/32220. Remove when the issue is fixed.
966+
// TODO Workaround for https://github.com/kubernetes/kubernetes/issues/32220. Remove when the issue is fixed.
967967
// If the resource already exists, the API server ordinarily returns an AlreadyExists error. Due to the above issue, if the resource has a non-empty metadata.generateName field, the API server returns a ServerTimeoutError. To ensure that the API server returns an AlreadyExists error, we set the metadata.generateName field to an empty string.
968968
if obj.GetName() != "" && obj.GetGenerateName() != "" {
969969
obj.SetGenerateName("")

cmd/clusterctl/client/repository/repository_gitlab.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ func (g *gitLabRepository) DefaultVersion() string {
118118

119119
// GetVersions returns the list of versions that are available in a provider repository.
120120
func (g *gitLabRepository) GetVersions(_ context.Context) ([]string, error) {
121-
// FIXME Get versions from GitLab API
121+
// TODO Get versions from GitLab API
122122
return []string{g.defaultVersion}, nil
123123
}
124124

internal/controllers/machinehealthcheck/machinehealthcheck_controller_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1420,7 +1420,7 @@ func TestMachineHealthCheck_Reconcile(t *testing.T) {
14201420
})
14211421

14221422
t.Run("when a machine is paused", func(t *testing.T) {
1423-
// FIXME: Resolve flaky/failing test
1423+
// TODO: Resolve flaky/failing test
14241424
t.Skip("skipping until made stable")
14251425
g := NewWithT(t)
14261426
cluster := createCluster(g, ns.Name)

0 commit comments

Comments
 (0)