Skip to content

Commit 74c28b0

Browse files
authored
Merge pull request #12474 from sbueringer/pr-minimum
⚠️ Add Minimum=0 marker to all MinReadySeconds fields
2 parents a21ffb0 + fe530e3 commit 74c28b0

9 files changed

+13
-0
lines changed

api/core/v1beta2/cluster_types.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -739,6 +739,7 @@ type MachineDeploymentTopology struct {
739739
// Defaults to 0 (machine will be considered available as soon as it
740740
// is ready)
741741
// +optional
742+
// +kubebuilder:validation:Minimum=0
742743
MinReadySeconds *int32 `json:"minReadySeconds,omitempty"`
743744

744745
// readinessGates specifies additional conditions to include when evaluating Machine Ready condition.
@@ -842,6 +843,7 @@ type MachinePoolTopology struct {
842843
// Defaults to 0 (machine will be considered available as soon as it
843844
// is ready)
844845
// +optional
846+
// +kubebuilder:validation:Minimum=0
845847
MinReadySeconds *int32 `json:"minReadySeconds,omitempty"`
846848

847849
// replicas is the number of nodes belonging to this pool.

api/core/v1beta2/clusterclass_types.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,7 @@ type MachineDeploymentClass struct {
327327
// is ready)
328328
// NOTE: This value can be overridden while defining a Cluster.Topology using this MachineDeploymentClass.
329329
// +optional
330+
// +kubebuilder:validation:Minimum=0
330331
MinReadySeconds *int32 `json:"minReadySeconds,omitempty"`
331332

332333
// readinessGates specifies additional conditions to include when evaluating Machine Ready condition.
@@ -497,6 +498,7 @@ type MachinePoolClass struct {
497498
// is ready)
498499
// NOTE: This value can be overridden while defining a Cluster.Topology using this MachinePoolClass.
499500
// +optional
501+
// +kubebuilder:validation:Minimum=0
500502
MinReadySeconds *int32 `json:"minReadySeconds,omitempty"`
501503
}
502504

api/core/v1beta2/machine_types.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -427,6 +427,7 @@ type MachineSpec struct {
427427
// minReadySeconds is the minimum number of seconds for which a Machine should be ready before considering it available.
428428
// Defaults to 0 (Machine will be considered available as soon as the Machine is ready)
429429
// +optional
430+
// +kubebuilder:validation:Minimum=0
430431
MinReadySeconds *int32 `json:"minReadySeconds,omitempty"`
431432

432433
// readinessGates specifies additional conditions to include when evaluating Machine Ready condition.

config/crd/bases/cluster.x-k8s.io_clusterclasses.yaml

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/cluster.x-k8s.io_clusters.yaml

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/cluster.x-k8s.io_machinedeployments.yaml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/cluster.x-k8s.io_machinepools.yaml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/cluster.x-k8s.io_machines.yaml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/cluster.x-k8s.io_machinesets.yaml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)