fix: errors.As

Signed-off-by: sivchari <shibuuuu5@gmail.com>

Author: sivchari

cmd/clusterctl/client/repository/repository_github.go

@@ -61,7 +61,7 @@ var (
 	retryableOperationTimeout  = 1 * time.Minute
 )
 
-var rateLimitError github.RateLimitError
+var rateLimitError *github.RateLimitError
 
 // gitHubRepository provides support for providers hosted on GitHub.
 //
@@ -505,7 +505,7 @@ func (g *gitHubRepository) handleGithubErr(err error, message string, args ...in
 		return errors.New("rate limit for github api has been reached. Please wait one hour or get a personal API token and assign it to the GITHUB_TOKEN environment variable")
 	}
 
-	var errorResponse github.ErrorResponse
+	var errorResponse *github.ErrorResponse
 	if errors.As(err, &errorResponse) {
 		ghErr := err.(*github.ErrorResponse)
 		if ghErr.Response.StatusCode == http.StatusNotFound {

internal/controllers/machine/machine_controller_noderef.go

@@ -74,6 +74,10 @@ func (r *Reconciler) reconcileNode(ctx context.Context, s *scope) (ctrl.Result,
 	node, err := r.getNode(ctx, remoteClient, *machine.Spec.ProviderID)
 	if err != nil {
 		if errors.Is(err, ErrNodeNotFound) {
+			if !s.machine.DeletionTimestamp.IsZero() {
+				// Tolerate node not found when the machine is being deleted.
+				return ctrl.Result{}, nil
+			}
 			// While a NodeRef is set in the status, failing to get that node means the node is deleted.
 			// If Status.NodeRef is not set before, node still can be in the provisioning state.
 			if machine.Status.NodeRef != nil {