Remove pointer, add omitzero & MinProperties for initialization fields/structs

Author: sbueringer

.golangci-kal.yml

@@ -159,7 +159,7 @@ linters:
         - kubeapilinter
     # KAL does not handle omitzero correctly yet: https://github.com/kubernetes-sigs/kube-api-linter/pull/115
     - path: "api/.*"
-      text: "optionalfields: field Status is optional and should (be a pointer|have the omitempty tag)"
+      text: "optionalfields: field (Status|Initialization) is optional and should (be a pointer|have the omitempty tag)"
       linters:
         - kubeapilinter
     - path: "api/bootstrap/kubeadm/v1beta2"

.golangci.yml

@@ -168,6 +168,10 @@ linters:
         # CAPI utils
         - pkg: sigs.k8s.io/cluster-api/util/conditions/deprecated/v1beta1
           alias: v1beta1conditions
+        - pkg: sigs.k8s.io/cluster-api/util/conditions
+          alias: ""
+        - pkg: sigs.k8s.io/cluster-api/util/patch
+          alias: ""
         - pkg: sigs.k8s.io/cluster-api/internal/topology/names
           alias: topologynames
         # CAPD

api/bootstrap/kubeadm/v1beta1/conversion.go

@@ -47,13 +47,10 @@ func (src *KubeadmConfig) ConvertTo(dstRaw conversion.Hub) error {
 
 	// Recover intent for bool values converted to *bool.
 	initialization := bootstrapv1.KubeadmConfigInitializationStatus{}
-	var restoredBootstrapDataSecretCreated *bool
-	if restored.Status.Initialization != nil {
-		restoredBootstrapDataSecretCreated = restored.Status.Initialization.DataSecretCreated
-	}
+	restoredBootstrapDataSecretCreated := restored.Status.Initialization.DataSecretCreated
 	clusterv1.Convert_bool_To_Pointer_bool(src.Status.Ready, ok, restoredBootstrapDataSecretCreated, &initialization.DataSecretCreated)
 	if !reflect.DeepEqual(initialization, bootstrapv1.KubeadmConfigInitializationStatus{}) {
-		dst.Status.Initialization = &initialization
+		dst.Status.Initialization = initialization
 	}
 	if err := RestoreBoolIntentKubeadmConfigSpec(&src.Spec, &dst.Spec, ok, &restored.Spec); err != nil {
 		return err
@@ -363,9 +360,7 @@ func Convert_v1beta2_KubeadmConfigStatus_To_v1beta1_KubeadmConfigStatus(in *boot
 	}
 
 	// Move initialization to old fields
-	if in.Initialization != nil {
-		out.Ready = ptr.Deref(in.Initialization.DataSecretCreated, false)
-	}
+	out.Ready = ptr.Deref(in.Initialization.DataSecretCreated, false)
 
 	// Move new conditions (v1beta2) to the v1beta2 field.
 	if in.Conditions == nil {

api/bootstrap/kubeadm/v1beta1/conversion_test.go

@@ -102,13 +102,6 @@ func hubKubeadmConfigStatus(in *bootstrapv1.KubeadmConfigStatus, c randfill.Cont
 	if in.Deprecated.V1Beta1 == nil {
 		in.Deprecated.V1Beta1 = &bootstrapv1.KubeadmConfigV1Beta1DeprecatedStatus{}
 	}
-
-	// Drop empty structs with only omit empty fields.
-	if in.Initialization != nil {
-		if reflect.DeepEqual(in.Initialization, &bootstrapv1.KubeadmConfigInitializationStatus{}) {
-			in.Initialization = nil
-		}
-	}
 }
 
 func hubKubeadmConfigSpec(in *bootstrapv1.KubeadmConfigSpec, c randfill.Continue) {

api/bootstrap/kubeadm/v1beta2/kubeadmconfig_types.go

@@ -470,7 +470,7 @@ type KubeadmConfigStatus struct {
 	// initialization provides observations of the KubeadmConfig initialization process.
 	// NOTE: Fields in this struct are part of the Cluster API contract and are used to orchestrate initial Machine provisioning.
 	// +optional
-	Initialization *KubeadmConfigInitializationStatus `json:"initialization,omitempty"`
+	Initialization KubeadmConfigInitializationStatus `json:"initialization,omitempty,omitzero"`
 
 	// dataSecretName is the name of the secret that stores the bootstrap data script.
 	// +optional
@@ -489,6 +489,7 @@ type KubeadmConfigStatus struct {
 }
 
 // KubeadmConfigInitializationStatus provides observations of the KubeadmConfig initialization process.
+// +kubebuilder:validation:MinProperties=1
 type KubeadmConfigInitializationStatus struct {
 	// dataSecretCreated is true when the Machine's boostrap secret is created.
 	// NOTE: this field is part of the Cluster API contract, and it is used to orchestrate initial Machine provisioning.

api/bootstrap/kubeadm/v1beta2/zz_generated.deepcopy.go

@@ -65,13 +65,10 @@ func (src *KubeadmControlPlane) ConvertTo(dstRaw conversion.Hub) error {
 
 	// Recover intent for bool values converted to *bool.
 	initialization := controlplanev1.KubeadmControlPlaneInitializationStatus{}
-	var restoredControlPlaneInitialized *bool
-	if restored.Status.Initialization != nil {
-		restoredControlPlaneInitialized = restored.Status.Initialization.ControlPlaneInitialized
-	}
+	restoredControlPlaneInitialized := restored.Status.Initialization.ControlPlaneInitialized
 	clusterv1.Convert_bool_To_Pointer_bool(src.Status.Initialized, ok, restoredControlPlaneInitialized, &initialization.ControlPlaneInitialized)
 	if !reflect.DeepEqual(initialization, controlplanev1.KubeadmControlPlaneInitializationStatus{}) {
-		dst.Status.Initialization = &initialization
+		dst.Status.Initialization = initialization
 	}
 
 	if err := bootstrapv1beta1.RestoreBoolIntentKubeadmConfigSpec(&src.Spec.KubeadmConfigSpec, &dst.Spec.KubeadmConfigSpec, ok, &restored.Spec.KubeadmConfigSpec); err != nil {
@@ -201,9 +198,7 @@ func Convert_v1beta2_KubeadmControlPlaneStatus_To_v1beta1_KubeadmControlPlaneSta
 	}
 
 	// Move initialized to ControlPlaneInitialized, rebuild ready
-	if in.Initialization != nil {
-		out.Initialized = ptr.Deref(in.Initialization.ControlPlaneInitialized, false)
-	}
+	out.Initialized = ptr.Deref(in.Initialization.ControlPlaneInitialized, false)
 	out.Ready = out.ReadyReplicas > 0
 
 	// Move new conditions (v1beta2) and replica counter to the v1beta2 field.

api/controlplane/kubeadm/v1beta1/conversion.go

@@ -174,13 +174,6 @@ func hubKubeadmControlPlaneStatus(in *controlplanev1.KubeadmControlPlaneStatus,
 		in.Deprecated.V1Beta1 = &controlplanev1.KubeadmControlPlaneV1Beta1DeprecatedStatus{}
 	}
 
-	// Drop empty structs with only omit empty fields.
-	if in.Initialization != nil {
-		if reflect.DeepEqual(in.Initialization, &controlplanev1.KubeadmControlPlaneInitializationStatus{}) {
-			in.Initialization = nil
-		}
-	}
-
 	// nil becomes &0 after hub => spoke => hub conversion
 	// This is acceptable as usually Replicas is set and controllers using older apiVersions are not writing MachineSet status.
 	if in.Replicas == nil {

api/controlplane/kubeadm/v1beta1/conversion_test.go

@@ -637,7 +637,7 @@ type KubeadmControlPlaneStatus struct {
 	// initialization provides observations of the KubeadmControlPlane initialization process.
 	// NOTE: Fields in this struct are part of the Cluster API contract and are used to orchestrate initial Machine provisioning.
 	// +optional
-	Initialization *KubeadmControlPlaneInitializationStatus `json:"initialization,omitempty"`
+	Initialization KubeadmControlPlaneInitializationStatus `json:"initialization,omitempty,omitzero"`
 
 	// selector is the label selector in string format to avoid introspection
 	// by clients, and is used to provide the CRD-based integration for the
@@ -688,6 +688,7 @@ type KubeadmControlPlaneStatus struct {
 }
 
 // KubeadmControlPlaneInitializationStatus provides observations of the KubeadmControlPlane initialization process.
+// +kubebuilder:validation:MinProperties=1
 type KubeadmControlPlaneInitializationStatus struct {
 	// controlPlaneInitialized is true when the KubeadmControlPlane provider reports that the Kubernetes control plane is initialized;
 	// A control plane is considered initialized when it can accept requests, no matter if this happens before