🐛 Align random deletion policy behavior with the rest regarding deletion annotations

Right now, the `oldest` and `newest` deletion policies prioritize machines that have the `cluster.x-k8s.io/delete-machine` annotation over unhealthy machines when deciding which machines need to be deleted. This wasn't the case with the `random` deletion policy. This change aligns the latter to the rest, making it honor the deletion annotation.

Author: elizabeth-dev

internal/controllers/machineset/machineset_delete_policy.go

@@ -82,7 +82,7 @@ func randomDeletePolicy(machine *clusterv1.Machine) deletePriority {
 		return mustDelete
 	}
 	if _, ok := machine.ObjectMeta.Annotations[clusterv1.DeleteMachineAnnotation]; ok {
-		return betterDelete
+		return shouldDelete
 	}
 	if !isMachineHealthy(machine) {
 		return betterDelete

internal/controllers/machineset/machineset_delete_policy_test.go

@@ -200,9 +200,9 @@ func TestMachineToDelete(t *testing.T) {
 			desc: "func=randomDeletePolicy, DeleteMachineAnnotation, diff=1",
 			diff: 1,
 			machines: []*clusterv1.Machine{
-				healthyMachine,
+				betterDeleteMachine,
 				deleteMachineWithMachineAnnotation,
-				healthyMachine,
+				betterDeleteMachine,
 			},
 			expect: []*clusterv1.Machine{
 				deleteMachineWithMachineAnnotation,