Skip to content

Webhooks should handle dry run enabled admission requests #5373

@nawazkh

Description

@nawazkh

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

  • As of CAPZ v1.17.2, CAPZ uses custom Defaulter and Custom Validator for handling mutating and validating requests.
  • The admission requests are not handled by CAPZ, instead the Default, Create, Update and Delete methods are implemented by CAPZ webhooks.
  • While this implementation enables CAPZ to maintain just-required methods, CAPZ webhooks cannot differentiate if the admission request was of Type DryRun.
  • To be able to understand if the admission request is of type DryRun, CAPZ webhooks should have access to the complete admission request object.
  • This issue serves as a reminder to probe this proposal.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.priority/awaiting-more-evidenceLowest priority. Possibly useful, but not yet enough support to actually get it done.

    Type

    No type

    Projects

    Status

    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions