Switch to windows-2022 images by default and in e2e

[mboersma]

/kind cleanup

What needs cleanup:

Currently e2e tests and the default VM image code in CAPZ are still returning windows-2019 images, but these are deprecated and we've stopped publishing them.

We need to change a few variables to -2022 from -2019 and clean up any unit tests that break. But since we've had problems with this in the past (see #5192 and #4867), it's probably not going to just work and investigation will be needed.

Describe the solution you'd like

Anything else you would like to add:

[jsturtevant]

The Windows Server 2022 images patch images from May-November were broken for several networking issues: microsoft/Windows-Containers#516

We've updated our upstream testing so use the CAPZ community sub and the latest images (Patches from December2024+) and we have passing tests: https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-kubernetes-e2e-capz-master-containerd-nightly-windows/1883938461862334464

This may have been part of the issue that you were encountering

[desek]

I noticed there hasn't been any new Windows Server 2022 images published since 130.3.20240717. Any updates when we should expect new images to be published?

[mboersma]

@desek the CAPZ team stopped publishing reference images to the Azure Marketplace last fall, when #5167 was merged. Instead, we use a Community Gallery now.

See the docs at https://capz.sigs.k8s.io/self-managed/custom-images and please follow up here or in Slack if you have more questions.