Skip to content

Commit b75140b

Browse files
authored
Merge pull request #854 from Phaow/hotfix
test: use env var for enable driver install in e2e
2 parents 68c09ad + 91bcb2b commit b75140b

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

test/e2e/suite_test.go

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ const (
4141
reportDirEnv = "ARTIFACTS"
4242
testWindowsEnvVar = "TEST_WINDOWS"
4343
testWinServerVerEnvVar = "WINDOWS_SERVER_VERSION"
44+
preInstallDriverEnvVar = "PRE_INSTALL_SMB_PROVISIONER"
4445
defaultReportDir = "test/e2e"
4546
testSmbSourceEnvVar = "TEST_SMB_SOURCE"
4647
testSmbSecretNameEnvVar = "TEST_SMB_SECRET_NAME"
@@ -54,6 +55,7 @@ var (
5455
smbDriver *smb.Driver
5556
isWindowsCluster = os.Getenv(testWindowsEnvVar) != ""
5657
winServerVer = os.Getenv(testWinServerVerEnvVar)
58+
preInstallDriver = os.Getenv(preInstallDriverEnvVar) == "true"
5759
defaultStorageClassParameters = map[string]string{
5860
"source": getSmbTestEnvVarValue(testSmbSourceEnvVar, defaultSmbSource),
5961
"csi.storage.k8s.io/provisioner-secret-name": getSmbTestEnvVarValue(testSmbSecretNameEnvVar, defaultSmbSecretName),
@@ -142,8 +144,9 @@ var _ = ginkgo.BeforeSuite(func() {
142144
startLog: "create metrics service ...",
143145
endLog: "metrics service created",
144146
}
145-
146-
execTestCmd([]testCmd{installSMBProvisioner, e2eBootstrap, createMetricsSVC})
147+
if !preInstallDriver {
148+
execTestCmd([]testCmd{installSMBProvisioner, e2eBootstrap, createMetricsSVC})
149+
}
147150

148151
nodeid := os.Getenv("nodeid")
149152
options := smb.DriverOptions{
@@ -194,7 +197,9 @@ var _ = ginkgo.AfterSuite(func() {
194197
startLog: "create example deployments",
195198
endLog: "example deployments created",
196199
}
197-
execTestCmd([]testCmd{createExampleDeployment})
200+
if !preInstallDriver {
201+
execTestCmd([]testCmd{createExampleDeployment})
202+
}
198203
}
199204

200205
smbLog := testCmd{
@@ -209,7 +214,11 @@ var _ = ginkgo.AfterSuite(func() {
209214
startLog: "Uninstalling SMB CSI Driver...",
210215
endLog: "SMB Driver uninstalled",
211216
}
212-
execTestCmd([]testCmd{smbLog, e2eTeardown})
217+
e2eTeardownCmds := []testCmd{smbLog}
218+
if !preInstallDriver {
219+
e2eTeardownCmds = append(e2eTeardownCmds, e2eTeardown)
220+
}
221+
execTestCmd(e2eTeardownCmds)
213222

214223
// install/uninstall CSI Driver deployment scripts test
215224
installDriver := testCmd{
@@ -224,7 +233,9 @@ var _ = ginkgo.AfterSuite(func() {
224233
startLog: "===================uninstall CSI Driver deployment scripts test===================",
225234
endLog: "===================================================",
226235
}
227-
execTestCmd([]testCmd{installDriver, uninstallDriver})
236+
if !preInstallDriver {
237+
execTestCmd([]testCmd{installDriver, uninstallDriver})
238+
}
228239
})
229240

230241
func TestE2E(t *testing.T) {

0 commit comments

Comments
 (0)