Skip to content

Commit 0737748

Browse files
authored
Merge pull request #897 from andyzhangx/use-canary-windows-hp
chore: use canary-windows-hp image for host process deployment
2 parents def094d + f857bf2 commit 0737748

File tree

6 files changed

+11
-10
lines changed

6 files changed

+11
-10
lines changed

charts/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ The following table lists the configurable parameters of the latest SMB CSI Driv
127127
| `windows.kubelet` | configure kubelet directory path on Windows agent node | `'C:\var\lib\kubelet'` |
128128

129129
### Csi Proxy support on windows
130+
> if you have set `windows.useHostProcessContainers` as `true`, csi-proxy is not needed by CSI driver.
130131
131132
The helm can setup the host-process deamonset for the csi proxy, by setting windows.csiproxy.enabled to true.
132133

21 Bytes
Binary file not shown.

charts/latest/csi-driver-smb/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ windows:
159159
cpu: 10m
160160
memory: 40Mi
161161
csiproxy:
162-
enabled: false # required if windows.enabled is true, but may be installed manually also
162+
enabled: false # required if windows.enabled is true and useHostProcessContainers is false, but may be installed manually also
163163
dsName: csi-proxy-win # daemonset name
164164
tolerations: {}
165165
affinity: {}

deploy/csi-smb-node-windows-hostprocess.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ spec:
3434
hostNetwork: true
3535
initContainers:
3636
- name: init
37-
image: mcr.microsoft.com/k8s/csi/smb-csi:latest-windows-hp
37+
image: gcr.io/k8s-staging-sig-storage/smbplugin:canary-windows-hp
3838
imagePullPolicy: IfNotPresent
3939
command:
4040
- "powershell.exe"
@@ -69,7 +69,7 @@ spec:
6969
cpu: 30m
7070
memory: 40Mi
7171
- name: smb
72-
image: mcr.microsoft.com/k8s/csi/smb-csi:latest-windows-hp
72+
image: gcr.io/k8s-staging-sig-storage/smbplugin:canary-windows-hp
7373
imagePullPolicy: IfNotPresent
7474
command:
7575
- "smbplugin.exe"

deploy/example/smb-provisioner/smb-server-lb.yaml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,23 +34,22 @@ spec:
3434
"kubernetes.io/os": linux
3535
containers:
3636
- name: smb-server
37-
image: andyzhangx/samba:win-fix
37+
image: dockurr/samba
3838
env:
39-
- name: PERMISSIONS
40-
value: "0777"
41-
- name: USERNAME
39+
- name: NAME
40+
value: share
41+
- name: USER
4242
valueFrom:
4343
secretKeyRef:
4444
name: smbcreds
4545
key: username
46-
- name: PASSWORD
46+
- name: PASS
4747
valueFrom:
4848
secretKeyRef:
4949
name: smbcreds
5050
key: password
51-
args: ["-u", "$(USERNAME);$(PASSWORD)", "-s", "share;/smbshare/;yes;no;no;all;none", "-p"]
5251
volumeMounts:
53-
- mountPath: /smbshare
52+
- mountPath: /storage
5453
name: data-volume
5554
ports:
5655
- containerPort: 445

deploy/example/windows/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
## Feature Status: GA
77

88
## Prerequisite
9+
> if you have set `windows.useHostProcessContainers` as `true`, csi-proxy is not needed by CSI driver.
910
- [Install CSI-Proxy on Windows Node](https://github.com/kubernetes-csi/csi-proxy#installation)
1011
- install csi-proxy on k8s 1.23+ Windows node using host process daemonset directly
1112
```console

0 commit comments

Comments
 (0)