HPA and PDB are dropped for istio-ingressgateway

[fraenkel]

Validation Checklist

• I confirm that this is a Kubeflow-related issue.
• I am reporting this in the appropriate repository.
• I have followed the Kubeflow installation guidelines.
• The issue report is detailed and includes version numbers where applicable.
• This issue pertains to Kubeflow development.
• I am available to work on this issue.
• You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Version

master

Detailed Description

The latest istio 1.24.x manifests have dropped the HorizontalPodAutoScaler and PodDisruptionBudget for istio-ingressgateway.
This was present in prior Kubeflow releases.

Steps to Reproduce

The existing install.yaml only contains HPA and PDB for istiod.
If you perform a istioctl manifest generate -f profile.yaml they appear.
When the profile-overlay.yaml is applied, it disappears.

By adding

   components:
     ingressGateways:
+      - enabled: true
+        name: istio-ingressgateway
       # Cluster-local gateway for KFServing
       - enabled: true
         name: cluster-local-gateway

it appears again.
Lists are replaced not merged.

Screenshots or Videos (Optional)

No response

[juliusvonkohout]

Cc @akagami-harsh

[juliusvonkohout]

Please recheck after the merge of #3022

[fraenkel]

@juliusvonkohout The overlay wasn't updated so they are still missing.

[juliusvonkohout]

@fraenkel then please create a PR to fix it for istio and istio-cni. Also if you find other things to clean up / improve.