test(sdk): add test for storage_per_trial

Signed-off-by: truc0 <22969604+truc0@users.noreply.github.com>

Author: truc0

sdk/python/v1beta1/kubeflow/katib/api/katib_client.py

@@ -532,6 +532,8 @@ class name in this argument.
             if storage_per_trial:
                 if isinstance(storage_per_trial, dict):
                     storage_per_trial = [storage_per_trial]
+                elif not isinstance(storage_per_trial, list):
+                    raise ValueError("storage_per_trial must be a list of dictionaries")
                 for storage in storage_per_trial:
                     volume = None
                     if isinstance(storage["volume"], client.V1Volume):

sdk/python/v1beta1/kubeflow/katib/api/katib_client_test.py

@@ -404,6 +404,50 @@ def create_experiment(
         },
         ValueError,
     ),
+    (
+        "invalid storage_per_trial - type mismatch",
+        {
+            "name": "tune_test",
+            "objective": lambda x: print(f"a={x}"),
+            "parameters": {"a": katib.search.int(min=10, max=100)},
+            "storage_per_trial": "invalid",
+        },
+        ValueError,
+    ),
+    (
+        "invalid storage_per_trial - volume has no name",
+        {
+            "name": "tune_test",
+            "objective": lambda x: print(f"a={x}"),
+            "parameters": {"a": katib.search.int(min=10, max=100)},
+            "storage_per_trial": [
+                {
+                    "volume": {
+                        # do not provide name
+                        "type": "pvc",
+                    }
+                }
+            ],
+        },
+        ValueError,
+    ),
+    (
+        "invalid storage_per_trial - volume has no type",
+        {
+            "name": "tune_test",
+            "objective": lambda x: print(f"a={x}"),
+            "parameters": {"a": katib.search.int(min=10, max=100)},
+            "storage_per_trial": [
+                {
+                    "volume": {
+                        "name": "test-pvc",
+                        # do not provide type
+                    }
+                }
+            ],
+        },
+        ValueError,
+    ),
     (
         "invalid model_provider_parameters",
         {