Skip to content

Commit ffa803a

Browse files
Burning1020abel-von
andcommitted
add channel to get send result
Co-authored-by: Abel Feng <fshb1988@gmail.com>
1 parent 6695b08 commit ffa803a

File tree

4 files changed

+56
-16
lines changed

4 files changed

+56
-16
lines changed

src/asynchronous/client.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ use crate::r#async::stream::{
2727
};
2828
use crate::r#async::utils;
2929

30+
use super::stream::SendingMessage;
31+
3032
/// A ttrpc Client (async).
3133
#[derive(Clone)]
3234
pub struct Client {
@@ -78,7 +80,7 @@ impl Client {
7880
self.streams.lock().unwrap().insert(stream_id, tx);
7981

8082
self.req_tx
81-
.send(msg)
83+
.send(SendingMessage::new(msg))
8284
.await
8385
.map_err(|e| Error::Others(format!("Send packet to sender error {:?}", e)))?;
8486

@@ -131,7 +133,7 @@ impl Client {
131133
// TODO: check return
132134
self.streams.lock().unwrap().insert(stream_id, tx);
133135
self.req_tx
134-
.send(msg)
136+
.send(SendingMessage::new(msg))
135137
.await
136138
.map_err(|e| Error::Others(format!("Send packet to sender error {:?}", e)))?;
137139

@@ -196,7 +198,7 @@ struct ClientWriter {
196198

197199
#[async_trait]
198200
impl WriterDelegate for ClientWriter {
199-
async fn recv(&mut self) -> Option<GenMessage> {
201+
async fn recv(&mut self) -> Option<SendingMessage> {
200202
self.rx.recv().await
201203
}
202204

src/asynchronous/connection.rs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ use tokio::{
1616
use crate::error::Error;
1717
use crate::proto::GenMessage;
1818

19+
use super::stream::SendingMessage;
20+
1921
pub trait Builder {
2022
type Reader;
2123
type Writer;
@@ -25,7 +27,7 @@ pub trait Builder {
2527

2628
#[async_trait]
2729
pub trait WriterDelegate {
28-
async fn recv(&mut self) -> Option<GenMessage>;
30+
async fn recv(&mut self) -> Option<SendingMessage>;
2931
async fn disconnect(&self, msg: &GenMessage, e: Error);
3032
async fn exit(&self);
3133
}
@@ -57,12 +59,14 @@ where
5759
let (reader_delegate, mut writer_delegate) = builder.build();
5860

5961
let writer_task = tokio::spawn(async move {
60-
while let Some(msg) = writer_delegate.recv().await {
61-
trace!("write message: {:?}", msg);
62-
if let Err(e) = msg.write_to(&mut writer).await {
62+
while let Some(mut sending_msg) = writer_delegate.recv().await {
63+
trace!("write message: {:?}", sending_msg.msg);
64+
if let Err(e) = sending_msg.msg.write_to(&mut writer).await {
6365
error!("write_message got error: {:?}", e);
64-
writer_delegate.disconnect(&msg, e).await;
66+
sending_msg.send_result(Err(e.clone()));
67+
writer_delegate.disconnect(&sending_msg.msg, e).await;
6568
}
69+
sending_msg.send_result(Ok(()));
6670
}
6771
writer_delegate.exit().await;
6872
trace!("Writer task exit.");

src/asynchronous/server.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ use tokio::{
3030
#[cfg(target_os = "linux")]
3131
use tokio_vsock::VsockListener;
3232

33-
use crate::asynchronous::unix_incoming::UnixIncoming;
33+
use crate::asynchronous::{stream::SendingMessage, unix_incoming::UnixIncoming};
3434
use crate::common::{self, Domain};
3535
use crate::context;
3636
use crate::error::{get_status, Error, Result};
@@ -329,7 +329,7 @@ struct ServerWriter {
329329

330330
#[async_trait]
331331
impl WriterDelegate for ServerWriter {
332-
async fn recv(&mut self) -> Option<GenMessage> {
332+
async fn recv(&mut self) -> Option<SendingMessage> {
333333
self.rx.recv().await
334334
}
335335
async fn disconnect(&self, _msg: &GenMessage, _: Error) {}
@@ -437,7 +437,7 @@ impl HandlerContext {
437437
};
438438

439439
self.tx
440-
.send(msg)
440+
.send(SendingMessage::new(msg))
441441
.await
442442
.map_err(err_to_others_err!(e, "Send packet to sender error "))
443443
.ok();
@@ -644,7 +644,7 @@ impl HandlerContext {
644644
header: MessageHeader::new_response(stream_id, payload.len() as u32),
645645
payload,
646646
};
647-
tx.send(msg)
647+
tx.send(SendingMessage::new(msg))
648648
.await
649649
.map_err(err_to_others_err!(e, "Send packet to sender error "))
650650
}

src/asynchronous/stream.rs

Lines changed: 38 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,42 @@ use crate::proto::{
1717
MESSAGE_TYPE_DATA, MESSAGE_TYPE_RESPONSE,
1818
};
1919

20-
pub type MessageSender = mpsc::Sender<GenMessage>;
21-
pub type MessageReceiver = mpsc::Receiver<GenMessage>;
20+
pub type MessageSender = mpsc::Sender<SendingMessage>;
21+
pub type MessageReceiver = mpsc::Receiver<SendingMessage>;
2222

2323
pub type ResultSender = mpsc::Sender<Result<GenMessage>>;
2424
pub type ResultReceiver = mpsc::Receiver<Result<GenMessage>>;
2525

26+
#[derive(Debug)]
27+
pub struct SendingMessage {
28+
pub msg: GenMessage,
29+
pub result_chan: Option<tokio::sync::oneshot::Sender<Result<()>>>,
30+
}
31+
32+
impl SendingMessage {
33+
pub fn new(msg: GenMessage) -> Self {
34+
Self {
35+
msg,
36+
result_chan: None,
37+
}
38+
}
39+
pub fn new_with_result(
40+
msg: GenMessage,
41+
result_chan: tokio::sync::oneshot::Sender<Result<()>>,
42+
) -> Self {
43+
Self {
44+
msg,
45+
result_chan: Some(result_chan),
46+
}
47+
}
48+
49+
pub fn send_result(&mut self, result: Result<()>) {
50+
if let Some(result_ch) = self.result_chan.take() {
51+
result_ch.send(result).unwrap_or_default();
52+
}
53+
}
54+
}
55+
2656
#[derive(Debug)]
2757
pub struct ClientStream<Q, P> {
2858
tx: CSSender<Q>,
@@ -317,9 +347,13 @@ async fn _recv(rx: &mut ResultReceiver) -> Result<GenMessage> {
317347
}
318348

319349
async fn _send(tx: &MessageSender, msg: GenMessage) -> Result<()> {
320-
tx.send(msg)
350+
let (res_tx, res_rx) = tokio::sync::oneshot::channel();
351+
tx.send(SendingMessage::new_with_result(msg, res_tx))
352+
.await
353+
.map_err(|e| Error::Others(format!("Send data packet to sender error {:?}", e)))?;
354+
res_rx
321355
.await
322-
.map_err(|e| Error::Others(format!("Send data packet to sender error {:?}", e)))
356+
.map_err(|e| Error::Others(format!("Failed to wait send result {:?}", e)))?
323357
}
324358

325359
#[derive(Clone, Copy, Debug, PartialEq, Eq)]

0 commit comments

Comments
 (0)