Skip to content

Commit 31db085

Browse files
kspearrinkspearrin
committed
Updated anonymous function spacing
Added version unit test Updated preview image and manifest version for 1.4
1 parent 99c4157 commit 31db085

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+92
-78
lines changed

‎Tests/SnippetTests.cs

+36-22
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,17 @@ namespace Tests
88
[TestClass]
99
public class SnippetTests
1010
{
11+
// --- CONFIGURATION ---
1112
// update path to local project directory
12-
private string path = @"C:\Projects\Visual-Studio-jQuery-Code-Snippets\jQueryCodeSnippets";
13+
private string m_path = @"C:\Projects\Visual-Studio-jQuery-Code-Snippets\jQueryCodeSnippets";
14+
private string m_helpUrl = "https://github.com/kspearrin/Visual-Studio-jQuery-Code-Snippets";
15+
private string m_version = "1.4.0";
16+
// --- END CONFIGURATION ---
1317

1418
[TestMethod]
1519
public void SnippetTitlesAreCorrect()
1620
{
17-
foreach (var snippetFile in Directory.EnumerateFiles(path, "*.snippet", SearchOption.AllDirectories))
21+
foreach (var snippetFile in Directory.EnumerateFiles(m_path, "*.snippet", SearchOption.AllDirectories))
1822
{
1923
var filePaths = snippetFile.Split(new string[] { "\\" }, StringSplitOptions.None);
2024
var fileName = filePaths[filePaths.Length - 1];
@@ -25,15 +29,14 @@ public void SnippetTitlesAreCorrect()
2529

2630
var titleNode = snippetDoc.GetElementsByTagName("Title");
2731
var title = titleNode[0].InnerText;
28-
2932
Assert.IsTrue(snippetName == title);
3033
}
3134
}
3235

3336
[TestMethod]
3437
public void SnippetShortcutsAreCorrect()
3538
{
36-
foreach (var snippetFile in Directory.EnumerateFiles(path, "*.snippet", SearchOption.AllDirectories))
39+
foreach (var snippetFile in Directory.EnumerateFiles(m_path, "*.snippet", SearchOption.AllDirectories))
3740
{
3841
var filePaths = snippetFile.Split(new string[] { "\\" }, StringSplitOptions.None);
3942
var fileName = filePaths[filePaths.Length - 1];
@@ -44,44 +47,39 @@ public void SnippetShortcutsAreCorrect()
4447

4548
var shortcutNode = snippetDoc.GetElementsByTagName("Shortcut");
4649
var shortcut = shortcutNode[0].InnerText;
47-
4850
Assert.IsTrue(snippetName == shortcut);
4951
}
5052
}
5153

5254
[TestMethod]
5355
public void SnippetsHaveDescriptions()
5456
{
55-
foreach (var snippetFile in Directory.EnumerateFiles(path, "*.snippet", SearchOption.AllDirectories))
57+
foreach (var snippetFile in Directory.EnumerateFiles(m_path, "*.snippet", SearchOption.AllDirectories))
5658
{
5759
var snippetDoc = new XmlDocument();
5860
snippetDoc.Load(snippetFile);
5961

6062
var descriptionNode = snippetDoc.GetElementsByTagName("Description");
61-
62-
Assert.IsTrue(descriptionNode != null && descriptionNode[0].InnerText != null);
63+
Assert.IsTrue(descriptionNode != null);
6364

6465
var description = descriptionNode[0].InnerText;
65-
66-
Assert.IsTrue(description != string.Empty && description.Length > 10);
66+
Assert.IsTrue(!string.IsNullOrWhiteSpace(description) && description.Length > 10);
6767
}
6868
}
6969

7070
[TestMethod]
7171
public void SnippetsHaveAuthors()
7272
{
73-
foreach (var snippetFile in Directory.EnumerateFiles(path, "*.snippet", SearchOption.AllDirectories))
73+
foreach (var snippetFile in Directory.EnumerateFiles(m_path, "*.snippet", SearchOption.AllDirectories))
7474
{
7575
var snippetDoc = new XmlDocument();
7676
snippetDoc.Load(snippetFile);
7777

7878
var authorNode = snippetDoc.GetElementsByTagName("Author");
79-
80-
Assert.IsTrue(authorNode != null && authorNode[0].InnerText != null);
79+
Assert.IsTrue(authorNode != null);
8180

8281
var author = authorNode[0].InnerText;
83-
84-
Assert.IsTrue(author != string.Empty && author.Length > 5);
82+
Assert.IsTrue(!string.IsNullOrWhiteSpace(author) && author.Length > 5);
8583
}
8684
}
8785

@@ -90,30 +88,46 @@ public void SnippetsHaveHelpUrls()
9088
{
9189
var helpUrl = "https://github.com/kspearrin/Visual-Studio-jQuery-Code-Snippets";
9290

93-
foreach (var snippetFile in Directory.EnumerateFiles(path, "*.snippet", SearchOption.AllDirectories))
91+
foreach (var snippetFile in Directory.EnumerateFiles(m_path, "*.snippet", SearchOption.AllDirectories))
9492
{
9593
var snippetDoc = new XmlDocument();
9694
snippetDoc.Load(snippetFile);
9795

9896
var urlNode = snippetDoc.GetElementsByTagName("HelpUrl");
99-
100-
Assert.IsTrue(urlNode != null && urlNode[0].InnerText != null);
97+
Assert.IsTrue(urlNode != null);
10198

10299
var url = urlNode[0].InnerText;
103-
104-
Assert.IsTrue(url != string.Empty && url == helpUrl);
100+
Assert.IsTrue(!string.IsNullOrWhiteSpace(url) && url == helpUrl);
105101
}
106102
}
107103

108104
[TestMethod]
109105
public void SnippetsAreProperFormattedXml()
110106
{
111-
foreach (var snippetFile in Directory.EnumerateFiles(path, "*.snippet", SearchOption.AllDirectories))
107+
foreach (var snippetFile in Directory.EnumerateFiles(m_path, "*.snippet", SearchOption.AllDirectories))
112108
{
113109
var contents = File.ReadAllText(snippetFile);
114-
115110
Assert.IsTrue(contents.Contains("<?xml version=\"1.0\" encoding=\"utf-8\"?>"));
116111
}
117112
}
113+
114+
[TestMethod]
115+
public void SnippetsHaveCorrectVersion()
116+
{
117+
foreach (var snippetFile in Directory.EnumerateFiles(m_path, "*.snippet", SearchOption.AllDirectories))
118+
{
119+
var snippetDoc = new XmlDocument();
120+
snippetDoc.Load(snippetFile);
121+
122+
var snippetNode = snippetDoc.GetElementsByTagName("CodeSnippet");
123+
Assert.IsTrue(snippetNode != null);
124+
125+
var formatAttr = snippetNode[0].Attributes["Format"];
126+
Assert.IsTrue(formatAttr != null);
127+
128+
var format = formatAttr.InnerText;
129+
Assert.IsTrue(!string.IsNullOrWhiteSpace(format) && format == m_version);
130+
}
131+
}
118132
}
119133
}

‎jQueryCodeSnippets/JavaScript/jQuery/func.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
</Function>
2323
</Literal>
2424
</Declarations>
25-
<Code Language="javascript"><![CDATA[function($param$) { $end$ }]]></Code>
25+
<Code Language="javascript"><![CDATA[function ($param$) { $end$ }]]></Code>
2626
</Snippet>
2727
</CodeSnippet>
2828
</CodeSnippets>

‎jQueryCodeSnippets/JavaScript/jQuery/jqAjax.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
url: "$url$",
5555
data: "$data$",
5656
dataType: "$dataType$",
57-
success: function(response) {
57+
success: function (response) {
5858
$end$
5959
}
6060
});]]></Code>

‎jQueryCodeSnippets/JavaScript/jQuery/jqAjaxAspNetWebService.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
dataType: "$dataType$",
4242
url: "$url$",
4343
data: "$data$",
44-
success: function(response) {
44+
success: function (response) {
4545
$end$
4646
}
4747
});]]></Code>

‎jQueryCodeSnippets/JavaScript/jQuery/jqAttrSetFn.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
</Function>
2929
</Literal>
3030
</Declarations>
31-
<Code Language="javascript"><![CDATA[$$($selector$).attr($attributeName$, function(index, attr) {
31+
<Code Language="javascript"><![CDATA[$$($selector$).attr($attributeName$, function (index, attr) {
3232
$end$
3333
});]]></Code>
3434
</Snippet>

‎jQueryCodeSnippets/JavaScript/jQuery/jqBind.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
</Function>
2929
</Literal>
3030
</Declarations>
31-
<Code Language="javascript"><![CDATA[$$($selector$).bind($eventType$, function(e) {
31+
<Code Language="javascript"><![CDATA[$$($selector$).bind($eventType$, function (e) {
3232
$end$
3333
});]]></Code>
3434
</Snippet>

‎jQueryCodeSnippets/JavaScript/jQuery/jqBindWithData.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
</Function>
3636
</Literal>
3737
</Declarations>
38-
<Code Language="javascript"><![CDATA[$$($selector$).bind($eventType$, $eventData$, function(e) {
38+
<Code Language="javascript"><![CDATA[$$($selector$).bind($eventType$, $eventData$, function (e) {
3939
$end$
4040
});]]></Code>
4141
</Snippet>

‎jQueryCodeSnippets/JavaScript/jQuery/jqBlur.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</Function>
2222
</Literal>
2323
</Declarations>
24-
<Code Language="javascript"><![CDATA[$$($selector$).blur(function(e) {
24+
<Code Language="javascript"><![CDATA[$$($selector$).blur(function (e) {
2525
e.preventDefault();
2626
$end$
2727
});]]></Code>

‎jQueryCodeSnippets/JavaScript/jQuery/jqChange.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</Function>
2222
</Literal>
2323
</Declarations>
24-
<Code Language="javascript"><![CDATA[$$($selector$).change(function(e) {
24+
<Code Language="javascript"><![CDATA[$$($selector$).change(function (e) {
2525
e.preventDefault();
2626
$end$
2727
});]]></Code>

‎jQueryCodeSnippets/JavaScript/jQuery/jqClick.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</Function>
2222
</Literal>
2323
</Declarations>
24-
<Code Language="javascript"><![CDATA[$$($selector$).click(function(e) {
24+
<Code Language="javascript"><![CDATA[$$($selector$).click(function (e) {
2525
e.preventDefault();
2626
$end$
2727
});]]></Code>

‎jQueryCodeSnippets/JavaScript/jQuery/jqDocReady.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<Shortcut>jqDocReady</Shortcut>
1313
</Header>
1414
<Snippet>
15-
<Code Language="javascript"><![CDATA[$$(document).ready(function() {
15+
<Code Language="javascript"><![CDATA[$$(document).ready(function () {
1616
$end$
1717
});]]></Code>
1818
</Snippet>

‎jQueryCodeSnippets/JavaScript/jQuery/jqDocReadyShort.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<Shortcut>jqDocReadyShort</Shortcut>
1313
</Header>
1414
<Snippet>
15-
<Code Language="javascript"><![CDATA[$$(function() {
15+
<Code Language="javascript"><![CDATA[$$(function () {
1616
$end$
1717
});]]></Code>
1818
</Snippet>

‎jQueryCodeSnippets/JavaScript/jQuery/jqEach.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</Function>
2222
</Literal>
2323
</Declarations>
24-
<Code Language="javascript"><![CDATA[$$.each($collection$, function(indexInArray, valueOfElement) {
24+
<Code Language="javascript"><![CDATA[$$.each($collection$, function (indexInArray, valueOfElement) {
2525
$end$
2626
});]]></Code>
2727
</Snippet>

‎jQueryCodeSnippets/JavaScript/jQuery/jqEachElement.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</Function>
2222
</Literal>
2323
</Declarations>
24-
<Code Language="javascript"><![CDATA[$$($selector$).each(function(index, element) {
24+
<Code Language="javascript"><![CDATA[$$($selector$).each(function (index, element) {
2525
// element == this
2626
$end$
2727
});]]></Code>

‎jQueryCodeSnippets/JavaScript/jQuery/jqFadeInFull.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
</Function>
2929
</Literal>
3030
</Declarations>
31-
<Code Language="javascript"><![CDATA[$$($selector$).fadeIn($duration$, function() {
31+
<Code Language="javascript"><![CDATA[$$($selector$).fadeIn($duration$, function () {
3232
$end$
3333
});]]></Code>
3434
</Snippet>

‎jQueryCodeSnippets/JavaScript/jQuery/jqFadeOutFull.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
</Function>
2929
</Literal>
3030
</Declarations>
31-
<Code Language="javascript"><![CDATA[$$($selector$).fadeOut($duration$, function() {
31+
<Code Language="javascript"><![CDATA[$$($selector$).fadeOut($duration$, function () {
3232
$end$
3333
});]]></Code>
3434
</Snippet>

‎jQueryCodeSnippets/JavaScript/jQuery/jqFadeToFull.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
</Function>
3636
</Literal>
3737
</Declarations>
38-
<Code Language="javascript"><![CDATA[$$($selector$).fadeTo($duration$, $opacity$, function() {
38+
<Code Language="javascript"><![CDATA[$$($selector$).fadeTo($duration$, $opacity$, function () {
3939
$end$
4040
});]]></Code>
4141
</Snippet>

‎jQueryCodeSnippets/JavaScript/jQuery/jqFocus.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</Function>
2222
</Literal>
2323
</Declarations>
24-
<Code Language="javascript"><![CDATA[$$($selector$).focus(function(e) {
24+
<Code Language="javascript"><![CDATA[$$($selector$).focus(function (e) {
2525
e.preventDefault();
2626
$end$
2727
});]]></Code>

‎jQueryCodeSnippets/JavaScript/jQuery/jqGet.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
</Literal>
3737
</Declarations>
3838
<Code Language="javascript"><![CDATA[$$.get("$url$", $data$,
39-
function(data, textStatus, jqXHR) {
39+
function (data, textStatus, jqXHR) {
4040
$end$
4141
},
4242
"$dataType$"

‎jQueryCodeSnippets/JavaScript/jQuery/jqGetJson.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
</Literal>
3030
</Declarations>
3131
<Code Language="javascript"><![CDATA[$$.getJSON("$url$", $data$,
32-
function(data, textStatus, jqXHR) {
32+
function (data, textStatus, jqXHR) {
3333
$end$
3434
}
3535
);]]></Code>

‎jQueryCodeSnippets/JavaScript/jQuery/jqGetScript.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</Function>
2222
</Literal>
2323
</Declarations>
24-
<Code Language="javascript"><![CDATA[$$.getScript("$url$", function(script, textStatus, jqXHR) {
24+
<Code Language="javascript"><![CDATA[$$.getScript("$url$", function (script, textStatus, jqXHR) {
2525
$end$
2626
});]]></Code>
2727
</Snippet>

‎jQueryCodeSnippets/JavaScript/jQuery/jqHideFull.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
</Function>
2929
</Literal>
3030
</Declarations>
31-
<Code Language="javascript"><![CDATA[$$($selector$).hide($duration$, function() {
31+
<Code Language="javascript"><![CDATA[$$($selector$).hide($duration$, function () {
3232
$end$
3333
});]]></Code>
3434
</Snippet>

‎jQueryCodeSnippets/JavaScript/jQuery/jqHover.snippet

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
</Function>
2222
</Literal>
2323
</Declarations>
24-
<Code Language="javascript"><![CDATA[$$($selector$).hover(function() {
24+
<Code Language="javascript"><![CDATA[$$($selector$).hover(function () {
2525
// over
2626
$end$
27-
}, function() {
27+
}, function () {
2828
// out
2929
}
3030
);]]></Code>

‎jQueryCodeSnippets/JavaScript/jQuery/jqKeyDown.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</Function>
2222
</Literal>
2323
</Declarations>
24-
<Code Language="javascript"><![CDATA[$$($selector$).keydown(function(e) {
24+
<Code Language="javascript"><![CDATA[$$($selector$).keydown(function (e) {
2525
$end$
2626
});]]></Code>
2727
</Snippet>

‎jQueryCodeSnippets/JavaScript/jQuery/jqKeyPress.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</Function>
2222
</Literal>
2323
</Declarations>
24-
<Code Language="javascript"><![CDATA[$$($selector$).keypress(function(e) {
24+
<Code Language="javascript"><![CDATA[$$($selector$).keypress(function (e) {
2525
$end$
2626
});]]></Code>
2727
</Snippet>

‎jQueryCodeSnippets/JavaScript/jQuery/jqKeyUp.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</Function>
2222
</Literal>
2323
</Declarations>
24-
<Code Language="javascript"><![CDATA[$$($selector$).keyup(function(e) {
24+
<Code Language="javascript"><![CDATA[$$($selector$).keyup(function (e) {
2525
$end$
2626
});]]></Code>
2727
</Snippet>

‎jQueryCodeSnippets/JavaScript/jQuery/jqLoadGet.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
</Function>
3636
</Literal>
3737
</Declarations>
38-
<Code Language="javascript"><![CDATA[$$($selector$).load("$url$", "$data$", function(response, status, request) {
38+
<Code Language="javascript"><![CDATA[$$($selector$).load("$url$", "$data$", function (response, status, request) {
3939
this; // dom element
4040
$end$
4141
});]]></Code>

‎jQueryCodeSnippets/JavaScript/jQuery/jqLoadPost.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
</Function>
3636
</Literal>
3737
</Declarations>
38-
<Code Language="javascript"><![CDATA[$$($selector$).load("$url$", "$data$", function(response, status, request) {
38+
<Code Language="javascript"><![CDATA[$$($selector$).load("$url$", "$data$", function (response, status, request) {
3939
this; // dom element
4040
$end$
4141
});]]></Code>

‎jQueryCodeSnippets/JavaScript/jQuery/jqMap.snippet

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</Function>
2222
</Literal>
2323
</Declarations>
24-
<Code Language="javascript"><![CDATA[$$.map($arrayOrObject$, function(elementOrValue, indexOrKey) {
24+
<Code Language="javascript"><![CDATA[$$.map($arrayOrObject$, function (elementOrValue, indexOrKey) {
2525
$end$
2626
});]]></Code>
2727
</Snippet>

0 commit comments

Comments
 (0)