Skip to content

Commit 77837b8

Browse files
authored
Allow non-unique route names (#194)
1 parent 185ea69 commit 77837b8

24 files changed

+8745
-120
lines changed

.eslintrc.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
module.exports = {
2-
parser: '@typescript-eslint/parser',
32
extends: ['airbnb-base', 'plugin:jest/recommended', 'plugin:prettier/recommended'],
43
rules: {
4+
'no-nested-ternary': 'off',
55
'no-param-reassign': [
66
'error',
77
{
@@ -10,6 +10,7 @@ module.exports = {
1010
},
1111
],
1212
'no-plusplus': 'off',
13+
'no-use-before-define': 'off',
1314
},
1415
settings: {
1516
'import/resolver': {
@@ -21,9 +22,10 @@ module.exports = {
2122
overrides: [
2223
{
2324
files: ['**/*.ts'],
24-
extends: ['plugin:@typescript-eslint/recommended', 'prettier/@typescript-eslint'],
25+
extends: ['plugin:@typescript-eslint/recommended'],
2526
rules: {
26-
'@typescript-eslint/ban-ts-ignore': 'off',
27+
'@typescript-eslint/ban-types': 'off',
28+
'@typescript-eslint/no-explicit-any': 'off',
2729
'import/extensions': [
2830
'error',
2931
'ignorePackages',

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
# Dependencies
44
node_modules/
5-
package-lock.json
65
yarn.lock
76

87
# Compiled output

.travis.yml

Lines changed: 0 additions & 23 deletions
This file was deleted.

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
66
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
77

8+
## [Unreleased][unreleased]
9+
10+
- Add `uniqueRouteNameSep` option to `generateUrls(router, options)` to allow non-unique route names
11+
among different branches of nested routes and access them by uniquely generated name
12+
([#194](https://github.com/kriasoft/universal-router/pull/194))
13+
814
## [9.0.1] - 2020-03-11
915

1016
- Fix typings: `router.resolve()` and `context.next()` always return a promise now

dist/universal-router-generate-urls.js

Lines changed: 9 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/universal-router-generate-urls.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/universal-router-generate-urls.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/universal-router-generate-urls.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/universal-router-sync.js

Lines changed: 17 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/universal-router-sync.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)