Skip to content

Commit 3371462

Browse files
committed
issue #2291 fixed.
1 parent a0d4858 commit 3371462

File tree

9 files changed

+59
-45
lines changed

9 files changed

+59
-45
lines changed

packages/Webkul/Admin/src/Http/Controllers/Settings/SourceController.php

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace Webkul\Admin\Http\Controllers\Settings;
44

5+
use Exception;
56
use Illuminate\Http\JsonResponse;
67
use Illuminate\Support\Facades\Event;
78
use Illuminate\View\View;
@@ -91,17 +92,23 @@ public function destroy(int $id): JsonResponse
9192
{
9293
$source = $this->sourceRepository->findOrFail($id);
9394

95+
if ($source->leads()->count() > 0) {
96+
return new JsonResponse([
97+
'message' => trans('admin::app.settings.sources.index.delete-failed-associated-leads'),
98+
], 400);
99+
}
100+
94101
try {
95102
Event::dispatch('settings.source.delete.before', $id);
96103

97-
$source->delete($id);
104+
$source->delete();
98105

99106
Event::dispatch('settings.source.delete.after', $id);
100107

101108
return new JsonResponse([
102109
'message' => trans('admin::app.settings.sources.index.delete-success'),
103110
], 200);
104-
} catch (\Exception $exception) {
111+
} catch (Exception $exception) {
105112
return new JsonResponse([
106113
'message' => trans('admin::app.settings.sources.index.delete-failed'),
107114
], 400);

packages/Webkul/Admin/src/Resources/lang/ar/app.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -859,12 +859,13 @@
859859

860860
'sources' => [
861861
'index' => [
862-
'create-btn' => 'إنشاء مصدر',
863-
'create-success' => 'تم إنشاء المصدر بنجاح.',
864-
'delete-failed' => 'لا يمكن حذف المصدر.',
865-
'delete-success' => 'تم حذف المصدر بنجاح.',
866-
'title' => 'المصادر',
867-
'update-success' => 'تم تحديث المصدر بنجاح.',
862+
'title' => 'المصادر',
863+
'create-btn' => 'إنشاء مصدر',
864+
'create-success' => 'تم إنشاء المصدر بنجاح.',
865+
'delete-failed' => 'لا يمكن حذف المصدر.',
866+
'delete-success' => 'تم حذف المصدر بنجاح.',
867+
'update-success' => 'تم تحديث المصدر بنجاح.',
868+
'delete-failed-associated-leads' => 'لا يمكن حذف المصدر لأنه مرتبط بعملاء محتملين موجودين. يرجى فصل أو تحديث هؤلاء العملاء قبل الحذف.',
868869

869870
'datagrid' => [
870871
'delete' => 'حذف',

packages/Webkul/Admin/src/Resources/lang/en/app.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -861,12 +861,13 @@
861861

862862
'sources' => [
863863
'index' => [
864-
'create-btn' => 'Create Source',
865-
'create-success' => 'Source created successfully.',
866-
'delete-failed' => 'Source can not be deleted.',
867-
'delete-success' => 'Source deleted successfully.',
868-
'title' => 'Sources',
869-
'update-success' => 'Source updated successfully.',
864+
'title' => 'Sources',
865+
'create-btn' => 'Create Source',
866+
'create-success' => 'Source created successfully.',
867+
'delete-failed' => 'Source can not be deleted.',
868+
'delete-success' => 'Source deleted successfully.',
869+
'update-success' => 'Source updated successfully.',
870+
'delete-failed-associated-leads' => 'Source cannot be deleted because it is associated with existing leads. Please detach or update those leads before deletion.',
870871

871872
'datagrid' => [
872873
'delete' => 'Delete',

packages/Webkul/Admin/src/Resources/lang/es/app.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -863,12 +863,13 @@
863863

864864
'sources' => [
865865
'index' => [
866-
'create-btn' => 'Crear Fuente',
867-
'create-success' => 'Fuente creada con éxito.',
868-
'delete-failed' => 'No se puede eliminar la fuente.',
869-
'delete-success' => 'Fuente eliminada con éxito.',
870-
'title' => 'Fuentes',
871-
'update-success' => 'Fuente actualizada con éxito.',
866+
'title' => 'Fuentes',
867+
'create-btn' => 'Crear Fuente',
868+
'create-success' => 'Fuente creada con éxito.',
869+
'delete-failed' => 'No se puede eliminar la fuente.',
870+
'delete-success' => 'Fuente eliminada con éxito.',
871+
'update-success' => 'Fuente actualizada con éxito.',
872+
'delete-failed-associated-leads' => 'No se puede eliminar la fuente porque está asociada a clientes potenciales existentes. Por favor, desvincúlelos o actualícelos antes de eliminar.',
872873

873874
'datagrid' => [
874875
'delete' => 'Eliminar',

packages/Webkul/Admin/src/Resources/lang/fa/app.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -864,12 +864,13 @@
864864

865865
'sources' => [
866866
'index' => [
867-
'create-btn' => 'ایجاد منبع',
868-
'create-success' => 'منبع با موفقیت ایجاد شد.',
869-
'delete-failed' => 'منبع قابل حذف نیست.',
870-
'delete-success' => 'منبع با موفقیت حذف شد.',
871-
'title' => 'منابع',
872-
'update-success' => 'منبع با موفقیت به‌روزرسانی شد.',
867+
'title' => 'منابع',
868+
'create-btn' => 'ایجاد منبع',
869+
'create-success' => 'منبع با موفقیت ایجاد شد.',
870+
'delete-failed' => 'امکان حذف منبع وجود ندارد.',
871+
'delete-success' => 'منبع با موفقیت حذف شد.',
872+
'update-success' => 'منبع با موفقیت به‌روزرسانی شد.',
873+
'delete-failed-associated-leads' => 'نمی‌توان منبع را حذف کرد زیرا با سرنخ‌های موجود مرتبط است. لطفاً ابتدا آن‌ها را جدا کرده یا به‌روزرسانی کنید.',
873874

874875
'datagrid' => [
875876
'delete' => 'حذف',

packages/Webkul/Admin/src/Resources/lang/pt_BR/app.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -857,12 +857,13 @@
857857

858858
'sources' => [
859859
'index' => [
860-
'create-btn' => 'Adicionar Origem',
861-
'create-success' => 'Origem adicionada com sucesso.',
862-
'delete-failed' => 'Não é possível excluir a origem.',
863-
'delete-success' => 'Origem excluída com sucesso.',
864-
'title' => 'Origens',
865-
'update-success' => 'Origem atualizada com sucesso.',
860+
'title' => 'Fontes',
861+
'create-btn' => 'Criar Fonte',
862+
'create-success' => 'Fonte criada com sucesso.',
863+
'delete-failed' => 'Não foi possível excluir a fonte.',
864+
'delete-success' => 'Fonte excluída com sucesso.',
865+
'update-success' => 'Fonte atualizada com sucesso.',
866+
'delete-failed-associated-leads' => 'Não é possível excluir a fonte porque está associada a leads existentes. Por favor, desvincule ou atualize esses leads antes da exclusão.',
866867

867868
'datagrid' => [
868869
'delete' => 'Excluir',

packages/Webkul/Admin/src/Resources/lang/tr/app.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -863,12 +863,13 @@
863863

864864
'sources' => [
865865
'index' => [
866-
'create-btn' => 'Kaynak Oluştur',
867-
'create-success' => 'Kaynak başarıyla oluşturuldu.',
868-
'delete-failed' => 'Kaynak silinemedi.',
869-
'delete-success' => 'Kaynak başarıyla silindi.',
870-
'title' => 'Kaynaklar',
871-
'update-success' => 'Kaynak başarıyla güncellendi.',
866+
'title' => 'Kaynaklar',
867+
'create-btn' => 'Kaynak Oluştur',
868+
'create-success' => 'Kaynak başarıyla oluşturuldu.',
869+
'delete-failed' => 'Kaynak silinemedi.',
870+
'delete-success' => 'Kaynak başarıyla silindi.',
871+
'update-success' => 'Kaynak başarıyla güncellendi.',
872+
'delete-failed-associated-leads' => 'Kaynak silinemiyor çünkü mevcut adaylarla ilişkili. Lütfen bu adayları silmeden önce bağlantılarını kaldırın veya güncelleyin.',
872873

873874
'datagrid' => [
874875
'delete' => 'Sil',

packages/Webkul/Admin/src/Resources/lang/vi/app.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -859,12 +859,13 @@
859859

860860
'sources' => [
861861
'index' => [
862-
'create-btn' => 'Tạo Nguồn',
863-
'create-success' => 'Nguồn đã được tạo thành công.',
864-
'delete-failed' => 'Không thể xóa nguồn.',
865-
'delete-success' => 'Nguồn đã được xóa thành công.',
866-
'title' => 'Các Nguồn',
867-
'update-success' => 'Nguồn đã được cập nhật thành công.',
862+
'title' => 'Nguồn',
863+
'create-btn' => 'Tạo Nguồn',
864+
'create-success' => 'Tạo nguồn thành công.',
865+
'delete-failed' => 'Không thể xóa nguồn.',
866+
'delete-success' => 'Xóa nguồn thành công.',
867+
'update-success' => 'Cập nhật nguồn thành công.',
868+
'delete-failed-associated-leads' => 'Không thể xóa nguồn vì nó đang được liên kết với các khách hàng tiềm năng. Vui lòng hủy liên kết hoặc cập nhật các khách hàng đó trước khi xóa.',
868869

869870
'datagrid' => [
870871
'delete' => 'Xóa',

packages/Webkul/Lead/src/Models/Source.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,6 @@ class Source extends Model implements SourceContract
2323
*/
2424
public function leads()
2525
{
26-
return $this->hasMany(LeadProxy::modelClass());
26+
return $this->hasMany(LeadProxy::modelClass(), 'lead_source_id', 'id');
2727
}
2828
}

0 commit comments

Comments
 (0)