Skip to content

Reorganize and improve go code #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WillAbides opened this issue Nov 7, 2023 · 1 comment · Fixed by #479
Closed

Reorganize and improve go code #478

WillAbides opened this issue Nov 7, 2023 · 1 comment · Fixed by #479

Comments

@WillAbides
Copy link
Contributor

When working on #476 I noticed that Go benchmarks are a tough to work on because they are all in the same directory so editors interpret that as one big package with a lot of duplicate function names.

I propose changing the layout of the Go benchmarks to be more like the Rust layout. There would be a common/go package with a Run function that runs the benchmarked function and sends the results to :9001.

Each test directory would have a test-go subdirectory that contains a separate package for each Go benchmark. For example there would be json/json-go/goccy and json/json-go/jsoniter.

If this gets a 👍 I can do the work. I did a little bit of exploratory work with a few json benchmarks, and it won't take too long to apply that to the rest of the Go benchmarks.

@nuald
Copy link
Collaborator

nuald commented Nov 8, 2023

It's totally fine to reorganize the source code, especially considering how Go modules work. I guess after that we could finally drop GO111MODULE=auto, and please feel free to do that within you changes if you want.

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants