Skip to content

Commit bc4dfab

Browse files
authored
Merge pull request #525 from kool-dev/kool_cloud_exec_log_cluster
Kool Cloud Exec/Log Cluster Support
2 parents 2bc1897 + e35b78e commit bc4dfab

File tree

5 files changed

+16
-9
lines changed

5 files changed

+16
-9
lines changed

commands/cloud_deploy_exec.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,9 @@ func (e *KoolDeployExec) Execute(args []string) (err error) {
7777
return
7878
}
7979

80-
if cloudService, err = e.cloud.Authenticate(domain, service); err != nil {
80+
cluster := e.env.Get("KOOL_CLOUD_CLUSTER")
81+
82+
if cloudService, err = e.cloud.Authenticate(domain, service, cluster); err != nil {
8183
return
8284
}
8385

commands/cloud_deploy_logs.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,9 @@ func (e *KoolDeployLogs) Execute(args []string) (err error) {
7373
return
7474
}
7575

76-
if cloudService, err = e.cloud.Authenticate(domain, service); err != nil {
76+
cluster := e.env.Get("KOOL_CLOUD_CLUSTER")
77+
78+
if cloudService, err = e.cloud.Authenticate(domain, service, cluster); err != nil {
7779
return
7880
}
7981

commands/cloud_deploy_logs_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ type fakeK8S struct {
1515
CalledAuthenticate bool
1616
CalledAuthenticateParamDomain string
1717
CalledAuthenticateParamService string
18+
CalledAuthenticateParamCluster string
1819
MockAuthenticateCloudService string
1920
MockAuthenticateErr error
2021

@@ -29,10 +30,11 @@ type fakeK8S struct {
2930
CalledCleanupParamOut shell.OutputWritter
3031
}
3132

32-
func (f *fakeK8S) Authenticate(domain, service string) (cloudService string, err error) {
33+
func (f *fakeK8S) Authenticate(domain, service, cluster string) (cloudService string, err error) {
3334
f.CalledAuthenticate = true
3435
f.CalledAuthenticateParamDomain = domain
3536
f.CalledAuthenticateParamService = service
37+
f.CalledAuthenticateParamCluster = cluster
3638

3739
cloudService = f.MockAuthenticateCloudService
3840
err = f.MockAuthenticateErr

services/cloud/k8s/kubectl.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
)
1212

1313
type K8S interface {
14-
Authenticate(string, string) (string, error)
14+
Authenticate(string, string, string) (string, error)
1515
Kubectl(shell.PathChecker) (builder.Command, error)
1616
Cleanup(shell.OutputWritter)
1717
}
@@ -30,9 +30,10 @@ func NewDefaultK8S() *DefaultK8S {
3030
}
3131
}
3232

33-
func (k *DefaultK8S) Authenticate(domain, service string) (cloudService string, err error) {
33+
func (k *DefaultK8S) Authenticate(domain, service, cluster string) (cloudService string, err error) {
3434
k.deployExec.Body().Set("domain", domain)
3535
k.deployExec.Body().Set("service", service)
36+
k.deployExec.Body().Set("cluster", cluster)
3637

3738
if k.resp, err = k.deployExec.Call(); err != nil {
3839
return

services/cloud/k8s/kubectl_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ func TestAuthenticate(t *testing.T) {
1616
expectedErr := errors.New("call error")
1717
k.deployExec.Endpoint.(*api.DefaultEndpoint).MockErr(expectedErr)
1818

19-
if _, err := k.Authenticate("foo", "bar"); !errors.Is(err, expectedErr) {
19+
if _, err := k.Authenticate("foo", "bar", ""); !errors.Is(err, expectedErr) {
2020
t.Error("unexpected error return from Authenticate")
2121
}
2222

@@ -29,7 +29,7 @@ func TestAuthenticate(t *testing.T) {
2929
CA: "ca",
3030
})
3131

32-
if _, err := k.Authenticate("foo", "bar"); !strings.Contains(err.Error(), "failed to generate access credentials") {
32+
if _, err := k.Authenticate("foo", "bar", ""); !strings.Contains(err.Error(), "failed to generate access credentials") {
3333
t.Errorf("unexpected error from DeployExec call: %v", err)
3434
}
3535

@@ -43,7 +43,7 @@ func TestAuthenticate(t *testing.T) {
4343

4444
authTempPath = t.TempDir()
4545

46-
if cloudService, err := k.Authenticate("foo", "bar"); err != nil {
46+
if cloudService, err := k.Authenticate("foo", "bar", ""); err != nil {
4747
t.Errorf("unexpected error from Authenticate call: %v", err)
4848
} else if cloudService != "path" {
4949
t.Errorf("unexpected cloudService return: %s", cloudService)
@@ -104,7 +104,7 @@ func TestKubectl(t *testing.T) {
104104
t.Error("should get error before authenticating")
105105
}
106106

107-
_, _ = k.Authenticate("foo", "bar")
107+
_, _ = k.Authenticate("foo", "bar", "")
108108

109109
if cmd, _ := k.Kubectl(fakeShell); cmd.Cmd() != "kubectl" {
110110
t.Error("should use kubectl")

0 commit comments

Comments
 (0)