Skip to content

Conversation

@yasahi-hpc
Copy link
Contributor

This PR aims at introducing batched docs for lacgv.

  • docs for lacgv

Signed-off-by: yasahi-hpc <y.asahi6412@gmail.com>
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine but I would rephrase a little bit, the Kokkos View contains the values associated with the components of the vector. It technically does not contain a std::vector or something like that.

Type Requirements
-----------------

- ``XViewType`` must be a Kokkos `View <https://kokkos.org/kokkos-core-wiki/API/core/view/view.html>`_ of rank 1 containing a vector :math:`x`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ``XViewType`` must be a Kokkos `View <https://kokkos.org/kokkos-core-wiki/API/core/view/view.html>`_ of rank 1 containing a vector :math:`x`
- ``XViewType`` must be a Kokkos `View <https://kokkos.org/kokkos-core-wiki/API/core/view/view.html>`_ of rank 1 representing the vector :math:`x`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I have updated accordingly

Signed-off-by: yasahi-hpc <y.asahi6412@gmail.com>
@lucbv lucbv merged commit cd403c9 into kokkos:develop Oct 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants