Require KOKKOS_ENABLE_DEPRECATED_CODE_5 to be defined for including <Kokkos_ArithTraits.hpp>
#2798
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Kokkos_ArithTraits.hpp> Signed-off-by: Damien L-G <dalg24@gmail.com>
lucbv
approved these changes
Oct 2, 2025
|
@ndellingwood assuming we remove the old headers everywhere in Trilinos this should not have an impact on it but just want you to have an eye on this. |
yasahi-hpc
requested changes
Oct 2, 2025
Co-authored-by: yasahi-hpc <57478230+yasahi-hpc@users.noreply.github.com> Signed-off-by: Damien L-G <dalg24+github@gmail.com>
@lucbv thanks I'll keep an eye on it, hopefully I addressed all the header and namespace updates in Trilinos in trilinos/Trilinos#14515 and it shouldn't be an issue (my testing with kokkos-kernels@develop passed with that PR in any case) |
ndellingwood
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error out at compile-time otherwise