-
Notifications
You must be signed in to change notification settings - Fork 109
Update headers in preparation for the 5.0 release #2795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will wait for CI to finish running, should be good to merge in a few minutes. Thanks for taking the time to update our headers in line with the core library : )
|
Note that #2771 introduced a new header with the Kokkos 4 header and that is not handled in the current version of this PR |
|
Good point, I'll fix the header for KokkosKernels_ArithTraits |
Analog to kokkos/kokkos#8496
Interestingly I found some Kokkos 3 headers and a number of misformated Kokkos 4 headers.
You might want to checks the headers as part of the CI.