Skip to content

Conversation

@dalg24
Copy link
Member

@dalg24 dalg24 commented Sep 30, 2025

Analog to kokkos/kokkos#8496

Interestingly I found some Kokkos 3 headers and a number of misformated Kokkos 4 headers.
You might want to checks the headers as part of the CI.

Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
Copy link
Contributor

@yasahi-hpc yasahi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I use the version in my new PR.
Should we introduce REUSE-CI for license check?

Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for CI to finish running, should be good to merge in a few minutes. Thanks for taking the time to update our headers in line with the core library : )

@dalg24
Copy link
Member Author

dalg24 commented Oct 1, 2025

Note that #2771 introduced a new header with the Kokkos 4 header and that is not handled in the current version of this PR

@lucbv
Copy link
Contributor

lucbv commented Oct 1, 2025

Good point, I'll fix the header for KokkosKernels_ArithTraits

@lucbv lucbv merged commit f4dd87a into kokkos:develop Oct 2, 2025
24 of 35 checks passed
@dalg24 dalg24 deleted the update_headers branch October 2, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants