Skip to content

Conversation

@ndellingwood
Copy link
Contributor

No description provided.

ndellingwood and others added 14 commits September 9, 2025 18:14
Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>
* Added setNumRows/setNumCols to sparse matrix classes
* Update docs for crs/bsr with setNumCols
* Add documentation for ccs, coo matrices.
* Update header-docpage mapping

Signed-off-by: Brian Kelley <bmkelle@sandia.gov>
…okkos#2706)

The issue reports that Batched SVD hangs on a 3x6 matrix.
Adding it to our list of special matrices to test for will avoid
potential future regressions.

Limiting the maximum number of iterations by introducing
a for loop instead of a while loop and an input parameter to pass
a maximum number of iterations.

Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Signed-off-by: Vinh Dang <vqdang@sandia.gov>
This is the same workaround as kokkos#1889, but now for the spmv mv (rank-2) case.
Also add a new spmv test that replicates this kind of issue
for both rank-1 and rank-2 cases.

Signed-off-by: Brian Kelley <bmkelle@sandia.gov>
…kkos#2729)

* KokkosKernels_ENABLE_BENCHMARK -> KokkosKernels_ENABLE_BENCHMARKS

Signed-off-by: Carl Pearson <cwpears@sandia.gov>

* remove copy-pasted code from benchmarks/sparse/CMakeLists.txt

Signed-off-by: Carl Pearson <cwpears@sandia.gov>

---------

Signed-off-by: Carl Pearson <cwpears@sandia.gov>
…kokkos#2708)

* Add RCB to Graph component

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Add unit test for RCB

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Utility function to extract diagonal blocks in CRS format after RCB reordering

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Apply clang format

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Fix clang format

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Use explicit braces

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Looping along coordinate dimensions

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Use create_mirror instead of create_mirror_view

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Update the src_doc_mapping dictionary with empty values

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Update the src_doc_mapping dictionary

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Changes addressing comments

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Add input checks and move the algorithm implementation to impl

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Add documents

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Update docs

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Update graph-index.rst

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Update sparse-index.rst

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

---------

Signed-off-by: Vinh Dang <vqdang@sandia.gov>
…arse:sort_crs_matrix (kokkos#2714)

* Add optional SortType option

Signed-off-by: malphil <malphil@sandia.gov>

* Apply clang-format

Signed-off-by: malphil <malphil@sandia.gov>

* Suppress complaint around undocumented file

Signed-off-by: malphil <malphil@sandia.gov>

* Add in SandiaAI generated documentation file to please auto-tester

Signed-off-by: malphil <malphil@sandia.gov>

* Resolve issues related to documentation

Signed-off-by: malphil <malphil@sandia.gov>

* Address reviewer comments

Signed-off-by: malphil <malphil@sandia.gov>

* Fix title underline issue in docs

Signed-off-by: malphil <malphil@sandia.gov>

* Fix missing SortType -> SortAlgorithm

Signed-off-by: malphil <malphil@sandia.gov>

---------

Signed-off-by: malphil <malphil@sandia.gov>
Co-authored-by: malphil <malphil@sandia.gov>
…kkos#2721)

* Small update to RCB to avoid deprecated code
(HostMirror -> host_mirror_type)

* Clean up bulk sort disabled path
This was a workaround for a Kokkos issue that has been fixed
since 4.4, so the workaround is no longer needed.

Signed-off-by: Brian Kelley <bmkelle@sandia.gov>
Signed-off-by: Nuno Nobre <nuno.nobre@stfc.ac.uk>
Co-authored-by: Luc Berger <lberge@sandia.gov>
Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>
…s#2768)

* Update the bisect break condition in RCB (kokkos#2766)

* Update break condition in bisect

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Remove unused file

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* Use FOR loop as suggested

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

---------

Signed-off-by: Vinh Dang <vqdang@sandia.gov>

* update changelog - pr 2766

Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

---------

Signed-off-by: Vinh Dang <vqdang@sandia.gov>
Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>
Co-authored-by: Vinh Dang <vqdang@sandia.gov>
Part of Kokkos C++ Performance Portability Programming EcoSystem 4.7
Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>
@ndellingwood
Copy link
Contributor Author

Trilinos PR with 4.7.01 snapshots trilinos/Trilinos#14462 passed required checks

@ndellingwood ndellingwood added AT2-SPECIAL-APPROVAL Mark .github changes as approved. CI: skip-docs Do not run the documentation checks for this pull request AT2-CI-APPROVAL Approve CI to run at SNL labels Sep 17, 2025
@ndellingwood
Copy link
Contributor Author

ndellingwood commented Sep 17, 2025

A Trilinos AT2 / cuda12 failure https://sems-cdash-son.sandia.gov/cdash/tests/20724643 in PanzerMiniEM_Maxwell_MueLu_order1_tpl_MPI_4 is being retested

Edit: Tested the configuration manually and did not reproduce the test failure

@lucbv lucbv merged commit 6c5b5a3 into kokkos:master Sep 23, 2025
19 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT2-CI-APPROVAL Approve CI to run at SNL AT2-SPECIAL-APPROVAL Mark .github changes as approved. CI: skip-docs Do not run the documentation checks for this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants